Repository navigation
test(e2e): give the convergence and plugin-edit runs the time they take - #230
Merged
Merged
Conversation
Inside a loaded full suite (the Stop hook's run, load average around 20), two e2e tests ran out of vitest's default 60 s, while alone they take a few seconds: - logical-shorthand-convergence: an allOrders() is 15 `oxlint --fix` runs in a row and a test makes up to three. They now get 180 s each. - cache-dir's plugin edit: two cold precomputes, each of which its own `run` already allows 120 s. The test now gets 240 s, the sum. The same per-test budget oxlint-lsp's tests already have; nothing else changes. Claude-Session: https://claude.ai/code/session_019vTh6S5A41M1HLkmk3FaM1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Inside a loaded full suite (the Stop hook's run, load average around 20), two e2e tests ran out of vitest's default 60 s, while alone they take a few seconds. Both failures were timeouts, not wrong results:
logical-shorthand-convergence: anallOrders()is 15oxlint --fixruns in a row, and a test makes up to three (about 5 s alone). Each test now gets 180 s.cache-dir› editing a local@plugin: two cold precomputes, each of which its ownrunalready allows 120 s. The test now gets 240 s, the sum.oxlint-lsp's tests already have the same kind of per-test budget. Nothing else changes.Test plan
format:check, typecheck.🤖 Generated with Claude Code
https://claude.ai/code/session_019vTh6S5A41M1HLkmk3FaM1