Repository navigation
chore: vitest 5.0.2; fix a cache-prune test race - #209
Merged
Merged
Conversation
sergioazoc
force-pushed
the
docs/slim-readme
branch
from
September 26, 2026 20:32
0869c5e to
7b5d280
Compare
sergioazoc
force-pushed
the
chore/vitest-5.0.2
branch
from
September 26, 2026 20:32
906f921 to
450c2a4
Compare
sergioazoc
force-pushed
the
docs/slim-readme
branch
from
September 26, 2026 20:40
7b5d280 to
9080fe1
Compare
sergioazoc
force-pushed
the
chore/vitest-5.0.2
branch
from
September 26, 2026 20:40
450c2a4 to
2049dbb
Compare
5.0.2 is past pnpm's one-day wait now. The test that checks a cache hit refreshes an artifact over a day old aged it to 40 days, past the 30-day prune — and the run's cache dir is shared, so another file's precompute could prune it first (seen once in three runs). Two days tests the same thing without the race.
sergioazoc
force-pushed
the
chore/vitest-5.0.2
branch
from
September 26, 2026 20:46
2049dbb to
93aae49
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The second dependency pass of the 1.14.0 roadmap. Stacked on #208.
pnpm outdated -r).cache-prune.test.ts's "refreshes the artifact a cache hit reads once it is over a day old" aged the artifact to 40 days, which is past the 30-day prune. The run's cache dir is shared by every test file, so another file's precompute could prune the artifact before the second load (ENOENT, once in three runs). Aging it 2 days tests the same threshold without the race. In production this is harmless: a pruned artifact is only recomputed.Tests
pnpm testtwice more, then once more after the fix: 3506 + 312 tests each time. The fixed test passes three times in a row on its own.🤖 Generated with Claude Code
https://claude.ai/code/session_01RUT7rPMjxs3XUap9hf51ay