Skip to content

feat: add new module utils.classical_delay - #448

Merged
caitaozhan merged 4 commits into
masterfrom
feature/classical-delay-model
Aug 28, 2026
Merged

feat: add new module utils.classical_delay#448
caitaozhan merged 4 commits into
masterfrom
feature/classical-delay-model

Conversation

@caitaozhan

Copy link
Copy Markdown
Contributor

Added a new module utils.classical_delay.

The current delay for the classical delay is set to a constant value across all router pairs. See

def generate_classical(router_names: list, cc_delay: float) -> list:

This new module calculates the shortest path between two nodes in the network and sets the classical delay between the two nodes using a classical delay model.

I frequently do this in my projects. Now it is time to bring this piece of code into the codebase.

Comment thread sequence/utils/classical_delay.py Fixed
Comment thread sequence/utils/classical_delay.py Fixed
@github-code-quality

github-code-quality Bot commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

Code Coverage Overview

Languages: Python

Python / code-coverage/pytest

The overall line coverage in commit 89afee2 in the feature/classical-de... branch is 84%. The line coverage in commit 021ef42 in the master branch is 83%.

Show a line coverage summary of the most impacted files.
File master 021ef42 feature/classical-de... 89afee2 +/-
sequence/resour...ondition_set.py 44% 68% +24%
sequence/utils/...enerator_cli.py 0% 52% +52%
sequence/utils/...ics/registry.py 0% 87% +87%
sequence/utils/...ssical_delay.py 0% 91% +91%
sequence/utils/...ics/__init__.py 0% 97% +97%
sequence/utils/...metric_types.py 0% 98% +98%
tests/app/test_early_expire.py 0% 99% +99%
sequence/utils/.../event_types.py 0% 99% +99%
tests/utils/test_metrics.py 0% 100% +100%
sequence/utils/...rics/storage.py 0% 100% +100%

Updated August 27, 2026 20:26 UTC

@hayekr hayekr left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@caitaozhan
caitaozhan merged commit 183b3cc into master Aug 28, 2026
16 checks passed
@hayekr
hayekr deleted the feature/classical-delay-model branch August 28, 2026 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants