Add a subprocess job - #50
Conversation
neilmb
left a comment
There was a problem hiding this comment.
Does this mean that our queue has to be called process? Or are we meant to subclass this with a new method of the proper queue name that forwards on to self.process?
|
No, failing the presence of a queue-named method, |
| from . import logger | ||
|
|
||
|
|
||
| class SubprocessJob(object): |
There was a problem hiding this comment.
I'm not sure I would make this directly available in qless-py. I think it makes sense for our described use case, and if someone wants to do the same thing, it's not that hard for them to reproduce this work, but I wouldn't want to open every qless install up to this.
There was a problem hiding this comment.
Yeah... that's when my spidey sense began to activate. I could see myself using this pretty regularly, but for the folks out there who decided to run the thing as root...
Any ideas of how else to distribute it? A separate package?
There was a problem hiding this comment.
FWIW, even without this job, I think the privileged user comment in the README should stand just as a cautionary reminder.
I would be fine as a separate package. I would point out that this Job is essentially shell access for the qless worker user for any remote client that can submit jobs.
5960c6a to
5c43869
Compare
@neilmb @b4hand @lindseyreno -- this is what we'd discussed recently. I have mixed feelings about it, but as long as it's run under a service account, I suppose I don't see the problem.