Fix V1 release header preview - #21
Merged
Merged
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe v1.0.0 release header’s reduced-motion and animated image URLs were changed from version-scoped assets to assets hosted on the ChangesRelease asset references
Estimated code review effort: 1 (Trivial) | ~2 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
v1.0.0tag to the already-merged files onmain.main-hosted assets during draft review.Reason
GitHub does not create the release tag until publication. The previous tag-based raw URLs therefore returned HTTP 404 in the draft preview and GitHub displayed only the image alt text.
Files affected
docs/releases/v1.0.0.mdRuntime impact
None. Pet packages, installer routes, metadata, sprite hashes, and application behavior are unchanged.
UI impact
The GitHub release draft now renders the animated laboratory header before the release tag exists. The reduced-motion PNG fallback uses the same live source strategy. README and public-site UI are unchanged.
Migration impact
None. No migration, restart, refresh, or dashboard action is required.
Validation performed
image/gifandimage/pngcontent types.ace3035b3259efbc19a0f138eff3f23eeb191be572d04c1cf020f8613c0fc737.8866ccf0c891fd7245f3d7efac9dfe5025c9e8b54500308110184bcb2df9738f.<picture>, GIF URL, and reduced-motion source.1200 x 560; the laboratory composition was visually inspected; console errors/warnings: 0..codex/scripts/project_preflight.shpassed: 7 published pets, 61 site references, 81 Markdown references, privacy scan 84 candidates/0 matches.git diff --checkand staged diff checks passed.Deterministic lane-ordering risk: none. UI truth consistency risk: none; only the hosting ref changed and exact hashes match.
Rollback safety
Revert this commit to restore tag-based URLs. The GitHub release remains a separate draft and can be edited independently without affecting runtime or package files.
Summary by CodeRabbit