Skip to content

Validation testing refactor - #28

Merged
semohr merged 3 commits into
mainfrom
validation_testing_overhaul
Jul 30, 2026
Merged

Validation testing refactor#28
semohr merged 3 commits into
mainfrom
validation_testing_overhaul

Conversation

@semohr

@semohr semohr commented May 10, 2026

Copy link
Copy Markdown
Owner

This pull request makes validation tests backend-agnostic and introduces a shared set of reusable schemas and fixtures to unify testing across validation backends.

@semohr
semohr force-pushed the validation_testing_overhaul branch from 6623c5a to 0b1ae19 Compare May 10, 2026 17:16
@codecov

codecov Bot commented May 10, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.85%. Comparing base (4decca0) to head (247bc39).
⚠️ Report is 2 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #28      +/-   ##
==========================================
+ Coverage   95.83%   95.85%   +0.01%     
==========================================
  Files          16       17       +1     
  Lines         985      988       +3     
==========================================
+ Hits          944      947       +3     
  Misses         41       41              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@semohr
semohr force-pushed the validation_testing_overhaul branch from 0b1ae19 to 753542d Compare May 10, 2026 17:17
@semohr
semohr force-pushed the validation_testing_overhaul branch 2 times, most recently from 3bddae4 to 9082b61 Compare June 30, 2026 06:34

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Refactors the validation test suite to be backend-agnostic by introducing shared schemas/fixtures and moving validation tests into a dedicated tests/validation/ package, while cleaning up the previous backend-specific test file.

Changes:

  • Added shared validator fixtures + reusable schema/fixture definitions for validation backend testing.
  • Added a unified validation test suite that runs against all configured backends.
  • Removed the previous tests/test_validate.py backend-specific test module and updated the changelog.

Reviewed changes

Copilot reviewed 5 out of 7 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
uv.lock Updates locked dependency versions.
tests/validation/test_validate.py Adds backend-agnostic tests for to_json_schema() and validate().
tests/validation/conftest.py Introduces shared schemas and parametrized fixtures for backend testing.
tests/validation/init.py Marks tests.validation as a package.
tests/test_validate.py Removes old backend-specific tests.
src/eyconf/validation/backends/init.py Adds a public re-export surface for validator backends.
CHANGELOG.md Documents the upcoming test refactor.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread tests/validation/conftest.py
Comment thread tests/validation/conftest.py
Comment thread CHANGELOG.md Outdated
@semohr
semohr merged commit 5e41615 into main Jul 30, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants