Append versioned first-Knop MeshInventory facts

[djradon]

Summary

• preserve carried MeshInventory bytes as the exact prefix during versioned first-Knop weave
• append only owned membership, page, and history/state facts through the shared append planner
• reject conflicting working-inventory locators and legacy inventory-owned mutable progression before writes
• remove the legacy first-Knop block-replacement fallback
• regenerate and publish the affected Alice a.05 through a.30 fixture tail

Validation

• deno task ci: 924 passed
• deno task build:npm-lib: passed
• all Alice a.05 through a.30 Accord transitions pass against regenerated refs
• sidecar and branch reruns were reviewed as timestamp-only and discarded
• Alice fixture main exactly matches the accepted a.30 tree

Summary by CodeRabbit

• Bug Fixes

  • First-Knop MeshInventory updates now preserve carried bytes and facts as an exact prefix.
  • Conflicting Knop inventory locators are rejected without modifying files.
  • Stale inventory-owned progression is rejected pending explicit repair instead of being silently removed or retained.
  • Updated weave outputs preserve expected membership and resource-page facts.

• Documentation

  • Added release-note guidance describing the MeshInventory output changes and regenerated fixture references.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Team

Run ID: 3128566e-753f-457e-94db-13de31b7ebe2

📥 Commits

Reviewing files that changed from the base of the PR and between ae57834 and a9af98f.

📒 Files selected for processing (6)

• documentation/notes/wd.codebase-overview.md
• documentation/notes/wd.todo.md
• src/core/weave/mesh_inventory_renderers.ts
• src/core/weave/mesh_inventory_renderers_test.ts
• src/core/weave/weave_test.ts
• tests/integration/weave_test.ts

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.

---

📝 Walkthrough

Walkthrough

The first-Knop mesh inventory renderer now uses append planning. It preserves carried bytes and facts, appends required facts, returns exact bytes for semantic no-ops, and rejects conflicting or legacy mutable progression data. Unit, integration, fixture, and documentation updates cover these behaviors.

Changes

First-Knop inventory append

Layer / File(s)	Summary
Renderer append pipeline src/core/weave/mesh_inventory_renderers.ts	The renderer now prepares and plans inventory appends, rejects legacy progression predicates, and appends the _mesh Knop membership fact.
Renderer and fixture validation src/core/weave/mesh_inventory_renderers_test.ts, src/core/weave/weave_test.ts	Tests cover appended facts, exact no-op bytes, locator conflicts, legacy progression rejection, and parsed RDF assertions.
Integration behavior and release notes tests/integration/weave_test.ts, documentation/notes/*	Integration tests verify prefix preservation, semantic fixture output, and unchanged workspace state after rejection. Notes record the updated behavior.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Merge Risk: 🔵 Low · up to a9af9

The PR changes MeshInventory generation to preserve existing bytes and append versioned facts, while rejecting conflicting or legacy state. Because the resulting files are written sequentially, an interruption or concurrent operation could leave a partially updated local inventory; the change is mergeable with explicit owner awareness or follow-up for this bounded consistency risk.

Sequence Diagram(s)

sequenceDiagram
  participant Weave as Weave caller
  participant Renderer as renderFirstKnopWovenMeshInventoryTurtle
  participant Planner as inventory append planner
  Weave->>Renderer: current inventory and requested facts
  Renderer->>Renderer: assertNoLegacyFirstKnopInventoryProgression
  Renderer->>Planner: prepareCurrentInventory
  Planner->>Planner: planInventoryAppend
  Planner-->>Renderer: append plan
  Renderer->>Planner: renderInventoryAppendPlan
  Planner-->>Weave: woven inventory bytes

Loading

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 11 functions across 4 files. (2 skipped: 2…	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes the main change: appending versioned first-Knop MeshInventory facts.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

Full details: Docstring Coverage

Explanation

Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 11 functions across 4 files. (2 skipped: 2 unsupported.)

• Fix all pre-merge checks with AI

✨ Finishing Touches 💡 1

📝 Generate docstrings 💡

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch lane/versioned-first-knop-mesh-inventory-append

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!