fix(sdk,test): cascade-delete ephemeral chain validators (Bugbot high-sev follow-up to #428)

[bdchatham]

Follow-up to #428 — Bugbot high-severity finding

Bugbot flagged on #428 (verified valid): the integration harness's teardown orphans validator SeiNodes.

Root cause (confirmed in-tree)

• provision creates the genesis SeiNetwork; teardown deletes it + the RPC SeiNodes.
• The CRD defaults DeletionPolicy=Retain (+kubebuilder:default=Retain, seinetwork_types.go:98), and under Retain the controller strips the validator children's ownerRef (removeOwnerRef, internal/controller/seinetwork/nodes.go:301) so they survive network deletion.
• The validators are controller-created → they never carry sei.io/harness-run → neither t.Cleanup nor the label-GC sweep reaps them. Leaks 4 validators + PVCs every run in the shared nightly namespace.

Fix

• Add DeletionPolicy to the SDK NetworkSpec (plain string + DeletionDelete/DeletionRetain constants — core stays stdlib-only; threaded into renderNetwork). Same additive one-way-door pattern as Labels (feat(test): WS-I sei integration suite — TestBenchmark provision spine [DRAFT] #428).
• The harness sets DeletionDelete — an ephemeral chain cascade-deletes its validators (+ PVCs) on teardown. Correct for a throwaway test chain (distinct from production fleet nodes, which stay Retain).
• Locked by a render_test assertion that DeletionPolicy threads through.

Verification

go build ./... clean · go test ./sdk/... pass (incl. new assertion) · go test -c -tags integration compiles · golangci-lint 0 issues.

🤖 Generated with Claude Code

[cursor]

PR Summary

Low Risk
Additive SDK field with harness-only default for test chains; production callers omit it and keep CRD Retain behavior.

Overview
Fixes validator SeiNode + PVC leaks when the integration harness tears down a SeiNetwork: the CRD default DeletionPolicy=Retain orphans controller-created validators that never get sei.io/harness-run, so normal cleanup and label-GC cannot reap them.

The SDK gains NetworkSpec.DeletionPolicy (DeletionDelete / DeletionRetain string constants) and renderNetwork maps it to spec.deletionPolicy (empty string keeps Retain). provision in the integration harness sets DeletionDelete for ephemeral nightly chains. A render_test assertion locks the mapping.

Integration package comments in benchmark_test.go and harness_test.go are trimmed; behavior is unchanged aside from the deletion policy.

^{Reviewed by Cursor Bugbot for commit d9d6b00. Bugbot is set up for automated code reviews on this repo. Configure here.}

[bdchatham]

Comment-standards expert review applied (idiom D10 + prose register)

Per request, ran a two-lens review scoped to comment register across the WS-I harness + SDK surface. Both converged; all findings applied in d9d6b00:

• stripped meta/ID cruft from code comments (Bugbot high-sev, WS-I step N, decision D*) — that context lives here in the PR, not in source
• dropped migration-history framing (replaces…, used to pass…) → present-state only
• fixed one drift (gating): TestBenchmark's doc claimed seiload drive/report the body t.Skips
• trimmed agent-verbose package doc + de-duplicated the DeletionPolicy rationale to one canonical home

Vetted-clean and kept: the // -> spec.X field mappings, blank-import rationale, SIGTERM/why comments — the standard is why-not-what + crisp, not fewer comments.

Durable follow-up the idiom lens recommended: graduate this into /pr-quality as a grep gate (Bugbot|WS-I|xreview|decision D[0-9] in *.go comments outside TODO() so it's mechanically enforced. Will forward to Tide.