Skip to content

fix: correct feedback sentiment and tech partner metrics - #91

Open
nehayadav827 wants to merge 1 commit into
seetadev:mainfrom
nehayadav827:fix-feedback-sentiment-metrics
Open

nehayadav827 wants to merge 1 commit into
seetadev:mainfrom
nehayadav827:fix-feedback-sentiment-metrics

Conversation

@nehayadav827

Copy link
Copy Markdown

Description

This PR fixes two data correctness issues in src/lib/data-processing.ts related to BuilderOS analytics and contribution metrics.

What problem does it solve?

  1. feedbackSentiment previously hardcoded neutral and negative feedback counts to 0, preventing the dashboard from surfacing actual sentiment distribution.

  2. calculateTechPartnerMetrics() grouped directly by Which Tech Partner, causing values like "Libp2p, Storacha" to be treated as a single combined partner instead of separate normalized partners.

Relates to #68


Changes

  • Fix
  • Added calculateNeutralFeedback() and calculateNegativeFeedback()
  • Updated feedbackSentiment to use real calculated values
  • Refactored calculateTechPartnerMetrics() to use normalizeTechPartners()
  • Improved multi-partner metric aggregation logic
    -[x] Kept changes scoped to src/lib/data-processing.ts

Screenshots / Demo

Updated feedback sentiment flow

Screenshot 2026-05-19 191802

Updated tech partner normalization logic

Screenshot 2026-05-19 191221

Diff statistics and formatting validation

Screenshot 2026-05-19 191151 Screenshot 2026-05-19 190850

Additional Notes

Validation performed:

  • git --no-pager diff --check passes successfully.
  • npm run lint currently opens the interactive Next.js ESLint setup prompt.
  • Existing unrelated test/type issues are present in src/lib/__tests__/utils.test.ts.

No breaking changes introduced.


Checklist

  • I have tested this code
  • I have added necessary documentation
  • I have linked relevant issue(s)
  • I followed the code style of the project
  • I reviewed my own code

@vercel

vercel Bot commented May 19, 2026

Copy link
Copy Markdown

@nehayadav827 is attempting to deploy a commit to the SEETA's projects Team on Vercel.

A member of the Team first needs to authorize it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant