Skip to content

fix: queue pageSize to get more than 10 downloading items in Servarr - #1055

Draft
Mavyre wants to merge 3 commits into
seerr-team:developfrom
Mavyre:patch-1
Draft

Mavyre wants to merge 3 commits into
seerr-team:developfrom
Mavyre:patch-1

Conversation

@Mavyre

@Mavyre Mavyre commented Oct 28, 2024

Copy link
Copy Markdown

Allows to get all processing Series when entire seasons are downloded on Sonarr

Description

When downloading Season packs, Jellyseerr wasn't displaying all the downloading episodes due to Servarr default pageSize set to 10. 1000 should be a safe number to display correctly the processing items while downloading multiple Seasons (or season with >10 episodes) in parallel.

Screenshot (if UI-related)

Not UI related

To-Dos

  • Successful build pnpm build
  • Translation keys pnpm i18n:extract
  • Database migration (if required)

Issues Fixed or Closed

None

…r/Radarr

Allows to get all processing Series when entire seasons are downloded on Sonarr
@Mavyre Mavyre changed the title Updated queue pageSize to get more than 10 downloading items in Servarr fix: queue pageSize to get more than 10 downloading items in Servarr Oct 28, 2024

@gauthier-th gauthier-th left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the typing issue

@gauthier-th gauthier-th left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are still failing.
Looks like prettier hasn't been executed: pnpm run format

@gauthier-th gauthier-th left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've just spoken to Fallenbagel about it, and we think this should be a setting. As he said:

Requesting excessive data from a slow CPU or a system that may experience I/O bottlenecks could cause performance degradation

meaning that it can potentially cause problems if hundreds of downloads are in progress (retrieved from a seedbox, for example).

Could you please refactor this so it's an option in the Radarr/Sonarr settings?

@Mavyre

Mavyre commented Nov 13, 2024

Copy link
Copy Markdown
Author

I've just spoken to Fallenbagel about it, and we think this should be a setting. As he said:

Requesting excessive data from a slow CPU or a system that may experience I/O bottlenecks could cause performance degradation

meaning that it can potentially cause problems if hundreds of downloads are in progress (retrieved from a seedbox, for example).

Could you please refactor this so it's an option in the Radarr/Sonarr settings?

Sure, but I'd have to check out Jellyseerr code a litttle bit more than just adding easily this option, to get things done properly. I'll need a more few weeks to have time to get into it.

Any help appreciated :)

@gauthier-th

Copy link
Copy Markdown
Member

I've just spoken to Fallenbagel about it, and we think this should be a setting. As he said:

Requesting excessive data from a slow CPU or a system that may experience I/O bottlenecks could cause performance degradation

meaning that it can potentially cause problems if hundreds of downloads are in progress (retrieved from a seedbox, for example).
Could you please refactor this so it's an option in the Radarr/Sonarr settings?

Sure, but I'd have to check out Jellyseerr code a litttle bit more than just adding easily this option, to get things done properly. I'll need a more few weeks to have time to get into it.

Any help appreciated :)

You'd want to add a number in the DVRSetting interface, then you can go in src/components/Settings/RadarrModal.tsx and src/components/Settings/SonarrModal.tsx to add the setting, and then get the pageSize setting from the place getQueue is called and pass it to the function.

@fallenbagel fallenbagel left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Mavyre are you able to continue with the PR with the changes requested or should I take over?

@fallenbagel
fallenbagel marked this pull request as draft January 15, 2025 17:21
@Mavyre

Mavyre commented Jan 15, 2025

Copy link
Copy Markdown
Author

Hey @fallenbagel,

Sorry, life has been busy lately! I'll do it next week-end and keep you posted!

@github-actions

github-actions Bot commented Apr 8, 2025

Copy link
Copy Markdown

This pull request has merge conflicts. Please resolve the conflicts so the PR can be successfully reviewed and merged.

@github-actions github-actions Bot added the merge conflict Cannot merge due to merge conflicts label Apr 8, 2025
@github-actions

Copy link
Copy Markdown

This PR is stale because it has been open 30 days with no activity. Please address the feedback or provide an update to keep it open.

@github-actions github-actions Bot added the stale label Nov 28, 2025
@github-actions

Copy link
Copy Markdown

This PR was closed because it has been stalled for 30 days with no activity. You can reopen it once you address the feedback or provide the requested changes.

@github-actions github-actions Bot closed this Dec 28, 2025
@fallenbagel

Copy link
Copy Markdown
Member

Re-opening since this would be a good QOL feature (needs to be updated to let the user configure the limit)

@fallenbagel fallenbagel reopened this Dec 29, 2025
@github-actions github-actions Bot removed the stale label Dec 29, 2025
@Mavyre

Mavyre commented Jan 3, 2026

Copy link
Copy Markdown
Author

Wow it's been a year already... I've got to rework it for the new seerr. I'm putting a reminder to get it done this month

@github-actions

github-actions Bot commented Feb 3, 2026

Copy link
Copy Markdown

This PR is stale because it has been open 30 days with no activity. Please address the feedback or provide an update to keep it open.

@github-actions github-actions Bot added the stale label Feb 3, 2026
@github-actions

github-actions Bot commented Mar 6, 2026

Copy link
Copy Markdown

This PR was closed because it has been stalled for 30 days with no activity. You can reopen it once you address the feedback or provide the requested changes.

@github-actions github-actions Bot closed this Mar 6, 2026
@github-actions

github-actions Bot commented Sep 4, 2026

Copy link
Copy Markdown

Hey @Mavyre, thanks for submitting this PR! However, it looks like the PR template hasn't been fully filled out.

Issues found:

  • How Has This Been Tested? section is empty.
  • Checklist section is missing or has been removed.
  • The contribution guidelines checkbox has not been checked.
  • The AI disclosure checkbox has not been checked.

Please update your PR description to follow the PR template.
Incomplete or missing PR descriptions may indicate insufficient review of the changes, and PRs that do not follow the template may be closed without review.
See our Contributing Guide for more details.

This check will automatically re-run when you edit your PR description.

@constbogdan

Copy link
Copy Markdown

Hello @Mavyre! I want tobuild on the idea you've proposed and offer my help.

I implemented and tested the queue synchronization changes in #3473. I saw the earlier feedback here about making the queue size configurable per Sonarr/Radarr server.

I'd be happy to update my implementation to add downloadQueueSize to the DVR settings, default it to 10, expose it in both server settings, and use it as a bounded maximum while retaining pagination.

My implementation also waits for RefreshMonitoredDownloads to complete and prevents overlapping Download Sync runs.

Would you be open to a new feat: PR implementing this, or would you prefer the work to continue through #1055?

@github-actions github-actions Bot removed the stale label Sep 4, 2026
@constbogdan

Copy link
Copy Markdown

Hi @Mavyre 👋, as @fallenbagel suggested I created a separate branch from develop and rebuilt #1055 on top keeping your original commit authorship.
Included the configurable Sonarr/Radarr download queue limit with default 10 + the changes from my previous PR #3473.

Passed all tests (207/207), Eslint and build.

How do we want to include these commits? I can give you the branch to cherry-pick if you want or if you have other preferences let me know!

@constbogdan

constbogdan commented Sep 4, 2026

Copy link
Copy Markdown

Pushed the completed branch pr-1055-current so you can take a look when you get a chance: compare

@constbogdan

Copy link
Copy Markdown

Hi @Mavyre, any update on this, would be a shame for this to be closed for lack of activity.

@fallenbagel

@Mavyre

Mavyre commented Sep 10, 2026

Copy link
Copy Markdown
Author

Hi @Mavyre, any update on this, would be a shame for this to be closed for lack of activity.

@fallenbagel

I thought it was fixed through another PR. It totally slipped my mind to redo that. Feel free to open a new PR (and reference this one for traceability), if you already did everything. Thanks for taking the time to do it 😃

@constbogdan

Copy link
Copy Markdown

Thanks @Mavyre. I opened #3535 with the completed implementation, preserving your original commit authorship and referencing #1055 for traceability. It also incorporates the queue-sync fixes from #3473 and the configurable per-server limit requested in the earlier review.

@fallenbagel @gauthier-th

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants