Repository navigation
Run httpbin before starting the tests - #164
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The retry test uses unsupported weighted /status syntax, causing it to fail in CI.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Configures integration tests to use a local HTTPBin service in CI instead of an external endpoint.
Changes:
- Adds configurable
HTTPBIN_URLsupport. - Updates backoff and error-handling tests.
- Starts go-httpbin in the GitHub Actions workflow.
File summaries
| File | Description |
|---|---|
tests/testExponentialBackoff.py |
Uses the configured HTTPBIN endpoint. |
tests/testErrorHandling.py |
Uses the configured HTTPBIN endpoint. |
tests/seatsioClientTest.py |
Adds configurable HTTPBIN URL resolution. |
.github/workflows/build.yml |
Starts HTTPBin and configures its URL. |
Review details
- Files reviewed: 4/4 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
mroloux
marked this pull request as ready for review
September 16, 2026 16:00
mroloux
requested review from
bverbeken and
schaloner
and removed request for
a team
September 16, 2026 16:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.