Skip to content

Support infinity for generators column_span parameter#355

Merged
jeparlefrancais merged 2 commits into
mainfrom
read-column-span-as-float
Jun 2, 2026
Merged

Support infinity for generators column_span parameter#355
jeparlefrancais merged 2 commits into
mainfrom
read-column-span-as-float

Conversation

@jeparlefrancais
Copy link
Copy Markdown
Contributor

@jeparlefrancais jeparlefrancais commented Jun 2, 2026

Closes #350

A small fix to deserialize the column_span parameter on the dense and readable generator as a float number. That way, since the config is read as json5, the max column can be set to infinity:

{
    generator: { name: "dense", column_span: Infinity },
}
  • add entry to the changelog

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 2, 2026

Coverage after merging read-column-span-as-float into main will be

85.05%

Coverage Report for Changed Files
FileStmtsBranchesFuncsLinesUncovered Lines
src/frontend
   configuration.rs82.02%100%80.60%82.28%114–117, 121–125, 129–132, 136–140, 143–146, 149–154, 157–159, 241–260, 262–263, 345–349, 81–83, 94–97
src/utils
   mod.rs96.48%100%96%96.58%65–66, 73
   serde_usize_from_float.rs57.89%100%100%55.56%12, 17–19, 22, 25–27

@jeparlefrancais jeparlefrancais merged commit 42f5482 into main Jun 2, 2026
6 checks passed
@jeparlefrancais jeparlefrancais deleted the read-column-span-as-float branch June 2, 2026 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

dense should accept json5 Infinity for 1 line minified files

1 participant