fix: improve prelex logic - #97
Closed
logic-finder wants to merge 2 commits into
Closed
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adjusts the prelex() selection logic used by hhss to pick random, non-duplicated sentence lines from the loaded sentence database.
Changes:
- Switches
lastposto represent the last valid element index (len - 1) instead of the length. - Splits the selection into “swap-based picks” plus a final “last pick” without swapping.
Contributor
Author
|
done |
Contributor
Author
|
I changed my mind--I think this change would harm the simplicity of the original code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To be honest, I don't think this modification give us much merit, at the expense of simplicity, but I just did it though.