Skip to content

Support numbers as words in English - #11

Open
Gallaecio wants to merge 11 commits into
scrapinghub:masterfrom
Gallaecio:localized-prices
Open

Gallaecio wants to merge 11 commits into
scrapinghub:masterfrom
Gallaecio:localized-prices

Conversation

@Gallaecio

@Gallaecio Gallaecio commented Jul 3, 2019

Copy link
Copy Markdown
Contributor

First step towards fixing #1

@Gallaecio Gallaecio changed the title [WIP] Support numbers as words in different locales Support numbers as words in different locales Dec 10, 2019
@Gallaecio Gallaecio changed the title Support numbers as words in different locales Support numbers as words in English Dec 10, 2019
@Gallaecio
Gallaecio marked this pull request as ready for review December 10, 2019 11:51
@codecov

codecov Bot commented Dec 10, 2019

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.49%. Comparing base (64e213a) to head (bc5b6e2).

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #11      +/-   ##
==========================================
+ Coverage   98.23%   98.49%   +0.26%     
==========================================
  Files           3        3              
  Lines         113      133      +20     
  Branches       16       19       +3     
==========================================
+ Hits          111      131      +20     
  Misses          1        1              
  Partials        1        1              
Files with missing lines Coverage Δ
price_parser/parser.py 98.11% <100.00%> (+0.43%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread price_parser/parser.py Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants