Repository navigation
fix: restore clean frontend CI checks - #416
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem and fix
Fresh frontend CI installs fail with Yarn YN0028 because the committed chat-ui workspace is missing from the lockfile. Once installation succeeds, the existing chat-ui sources fail the repository lint rules.
Register the existing workspace/dependencies in the lockfile, declare its already-used esbuild build dependency, and apply the existing repository formatting. Replace broad types with unknown or existing model types, remove unused bindings, and explain intentional parse/highlight fallbacks. Configure only the package build script for its existing ES module syntax, using the Node ESLint plugin's module configuration.
Add four compatibility tests and run them in frontend CI. Runtime behavior is preserved, including dynamic tool payloads, malformed JSON fallbacks, explicit file locations, and historical-turn change reports.
Validation
Scope
Built from clean main at 68c5054. Only chat-ui, its dependency/configuration records, and frontend CI/test wiring are included. No ACP Workbench, task hierarchy, submodule updates, or uncommitted shared-workspace changes are included. This separately unblocks the Feature Blueprint retirement in #415.