You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The JDK HttpClient maintains a single HTTP/2 connection per server and
client. Once the server-side limit of concurrent streams
(SETTINGS_MAX_CONCURRENT_STREAMS) is reached, further requests fail
immediately with "too many concurrent streams" - the client neither
waits for a free stream nor opens another connection.
A block in http.outcall.timeouts can now permit additional connections
for this case via "maxAdditionalConnections". If permitted, such a
request is sent via one of up to this many additional clients of its
client selector instead of failing right away. As the stream could not
be reserved, the request has not been sent yet and can safely be sent
again. If all connections are exhausted, the request fails as before.
Slow responses are still handled by the timeouts and the blacklist.
This is disabled by default (maxAdditionalConnections = 0) and only
takes effect for outcalls using a client selector.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- fixes: SE-15483
The key is always present due to the default block, so it can be read
directly from the extension config. Non-positive values disable
additional connections.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- fixes: SE-15483
The reason will be displayed to describe this comment to others. Learn more.
🟡 Changes recommended
Newly added clients can fail without retrying after a stream-limit race, and shared client reuse can exceed the current call’s configured additional-connection limit.
Adds an opt-in fallback for outbound HTTP/2 requests that hit a server’s concurrent-stream limit, intended for emergency use through configuration and a restart.
Changes:
Adds maxAdditionalConnections, disabled by default.
Caches additional HTTP clients per selector and retries requests after stream-limit failures.
Documents the fallback behavior and logs additional client creation.
File
Description
src/main/resources/component-050-kernel.conf
Defines and documents the default additional-connection limit.
The additional clients are shared per client selector, while the limit
is configured per call - only use as many of them as the current call
permits. Also try a newly added client within the retry loop, as other
requests might occupy its streams before the creating request is sent.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The reason will be displayed to describe this comment to others. Learn more.
🔵 Needs a closer look
Reassigning client causes subsequent redirects and OAuth retries to try a saturated additional client twice while skipping an available primary, leading to avoidable request failures.
No open issues 🎉
1 previously missed issue
In code that hasn't changed since last review
Keep the primary client as the starting client for retries
Assigning the additional client to client also makes it the starting client for subsequent redirects and OAuth retries. With one additional client, a follow-up request fails if that client's connection is saturated, even when the primary has capacity, because it tries the additional client twice and never tries the primary. Use a local variable for the additional send so the primary remains the starting client.
…ional connections
The additional client is no longer stored in the client field, so that redirects and the OAuth retry
start with the cached client again instead of re-trying a possibly exhausted additional client.
Also documents that this bypasses the server's stream limit and should only be enabled in coordination
with its operator, that additional clients are kept until the JVM is restarted, and that the feature has
no effect via the deprecated withConfiguredTimeout(String) or without a configured connectTimeout.
- fixes: SE-15483
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤖 AI-AssistedCreated with significant assistance of artificial intelligence tools🧬 EnhancementContains new features
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ymo-sci
added
🧬 Enhancement
Description
only added for emergency cases to be activatable with a simple restart via config.
Additional Notes
Checklist