ci: trim CodeRabbit tone_instructions and drop CODECOV_TOKEN - #114
Merged
Conversation
Follow-up to #113, which squash-merged before these two fixes landed: - .coderabbit.yaml: tone_instructions exceeded CodeRabbit's 250-char cap (CodeRabbit errors on the config); trimmed to 234 chars, same priorities. - ci.yml: drop the CODECOV_TOKEN reference — claustrum is a public repo, so codecov-action uploads tokenless; no secret needed. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughPR updates CodeRabbit's review tone instructions with refined phrasing and modifies GitHub Actions CI to use Codecov tokenless uploads, removing the secret token from the coverage workflow step. ChangesCodeRabbit review tone instructions
Codecov tokenless upload
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: 7cb1bf7f-31cf-4811-b0cb-5b3df286b356
📒 Files selected for processing (2)
.coderabbit.yaml.github/workflows/ci.yml
Tokenless eligibility depends on the Codecov org keeping public-repo token-auth disabled, not on the repo being public per se. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #113. That PR squash-merged before two fixes landed on its branch, so they never reached
main:.coderabbit.yaml— thetone_instructionsvalue was over CodeRabbit's 250-char cap, which CodeRabbit rejects when parsing the config. Trimmed to 234 chars with the same priorities (kept release-workflow correctness, JSON frame/field-order drift, concurrency/lifecycle, unix/windows parity, weak test assertions)..github/workflows/ci.yml— removed thetoken: ${{ secrets.CODECOV_TOKEN }}line. claustrum is a public repo, socodecov-actionuploads tokenless — noCODECOV_TOKENsecret required.Wire surface
Config only — no Go code, no impact on JSON-RPC frames.
🤖 Generated with Claude Code