fix: plainer telemetry consent, one-click GitHub sign-in - #44
Merged
Merged
Conversation
User feedback:
- The consent sheet now asks one plain question ("May Shepherd send
the following anonymously, about once a day?") with a short list:
app/macOS version and language, which features and how often,
amounts only roughly (1–3, 4–10, 11+), never names, titles or code.
Consent mechanics (equal buttons, Escape declines, EU/IP/controller
line, privacy link, reach switch) are unchanged.
- "Why device flow?": GitHub's browser flow still needs the
client_secret even with PKCE, so it stays. "Continue with device
flow" becomes "Sign in with GitHub", which copies the code and opens
github.com/login/device in one click. ADR 0004 amended.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Stk21d93DeKQXioFaZpWGm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User feedback, two of three points:
Shepherd/Telemetry/*. Consent mechanics unchanged.client_secreteven with PKCE, so the device flow stays; the button is now Sign in with GitHub and auto-copies the code + opensgithub.com/login/device. ADR 0004 amended; install docs (en/de) updated.Not in this PR: the blank screen after clicking "Full review" in the rail could not be reproduced in the demo (filled, empty and light/dark lane states all render).
🤖 Generated with Claude Code
https://claude.ai/code/session_01Stk21d93DeKQXioFaZpWGm