Repository navigation
fix(web): remove localhost hints from loading shell - #193
Merged
Merged
Conversation
Problem: Public SP42 briefly showed local-dev instructions during Wasm startup. Decision: Keep a generic loading message and guard it with a regression test. Rationale: Trunk ships shared index.html to online builds; dev-only guidance has no place in that shell. Validation: Regression test failed before the change and passes afterward.
schiste
marked this pull request as ready for review
October 7, 2026 09:15
|
You have reached your Codex usage limits for security reviews. Please try again later. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fix(web): remove local-server hints from online loading shell
Problem: Public SP42 briefly showed local-dev instructions during Wasm startup.
Decision: Keep a generic loading message and guard it with a regression test.
Rationale: Trunk ships shared index.html to online builds; dev-only guidance has no place in that shell.
Describe the change and the problem it solves.
Type
Validation Required
Regression test failed before the change and passes afterward.
List the checks you ran. PRs without validation notes may be returned before
review.
Risk
Notes For Reviewers
Call out anything that deserves extra attention.
Commits:
Opened by aethyme broker push as a draft.