Skip to content

chore(aethyme): activate canonical repository deployment - #192

Merged
schiste merged 1 commit into
mainfrom
agent/deliver-canonical-aethyme-activation-for
Oct 4, 2026
Merged

schiste merged 1 commit into
mainfrom
agent/deliver-canonical-aethyme-activation-for

Conversation

@schiste

@schiste schiste commented Oct 4, 2026

Copy link
Copy Markdown
Owner

Summary

Push and review canonical Aethyme activation

Describe the change and the problem it solves.

Type

  • Bug fix
  • Feature
  • Refactor
  • Documentation
  • Build, CI, or release
  • Security-sensitive change

Validation Required

List the checks you ran. PRs without validation notes may be returned before
review.

./scripts/check-focused.sh

Risk

  • Touches auth/session/cookies/CSRF
  • Touches deployment/runtime configuration
  • Touches desktop packaging
  • Touches scoring or Wikimedia action behavior
  • Needs an ADR

Notes For Reviewers

Call out anything that deserves extra attention.

Commits:

  • 0b8b81f chore(aethyme): activate canonical repository deployment

Opened by aethyme broker push as a draft.

@schiste
schiste marked this pull request as ready for review October 4, 2026 08:01
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for security reviews. Please try again later.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 4, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-04T08:05:04.405355Z 0b8b81f Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0b8b81f08f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread AGENTS.md
mandatory. If it does not exist, continue normally: do not run Aethyme, probe
for its binary, install it, or mention its absence.
<!-- aethyme-local:end -->
<!-- AETHYME:END generated -->

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Keep the main-base override when activating the broker

Replacing the optional-activation tail makes the broker instructions unconditional, but the command at line 18 still omits --base main. When refs/heads/aethyme/integration exists, .aethyme/config.toml:8-30 documents that the broker selects that potentially stale ref instead of main and has already based sessions on another agent's unmerged work. Preserve the repository-specific aethyme broker start --base main ... override in the generated instructions before enabling them globally.

Useful? React with 👍 / 👎.


## Supporting Commands

- `cargo run` (dev; medium confidence from `Cargo.toml`)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Name the binary in the generated dev command

The root manifest is a virtual workspace with six runnable binaries and no default-run, so following this new Start Here command exits with cargo run could not determine which binary to run rather than starting the application. Use the repository's actual development entrypoint, such as SP42_DEPLOYMENT_MODE=local cargo run -p sp42-server or scripts/dev-local.sh, and update the duplicate in repo-act as well. The repository instructions identify Procfile:web as the app entrypoint rather than an unqualified Cargo target.

AGENTS.md reference: AGENTS.md:L11-L12

Useful? React with 👍 / 👎.

@schiste
schiste merged commit 4870b56 into main Oct 4, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant