Skip to content

refactor(cursor-vpet): hexagonal architecture, modular bootstrap and expanded tests - #9

Open
jcendal wants to merge 25 commits into
sbugallo:mainfrom
jcendal:refactor/cursor-vpet-modern-patterns
Open

jcendal wants to merge 25 commits into
sbugallo:mainfrom
jcendal:refactor/cursor-vpet-modern-patterns

Conversation

@jcendal

@jcendal jcendal commented Sep 11, 2026

Copy link
Copy Markdown

Summary

Refactors packages/cursor-vpet with modern patterns while preserving functional behavior and pet.db compatibility.

Base: feat/unify-evolution-behavior
Scope: 11 commits · 85 files · +4635 / −666 lines (cursor-vpet only)

Architecture

  • Adds shared utilities (shared/) and SQLite foundations (errors, options, removes sqljs-runtime).
  • Introduces VS Code ports (notification, scheduler, animation-sink, webview-messenger) and typed webview messages.
  • Isolates pure presentation under webview/presentation/ and moves panels to webview/panels/ with stricter CSP.
  • Decomposes the sidebar into provider, presenter, orchestrator, and animation-host.
  • Modular bootstrap (container, register-commands, register-sidebar, ensure-hooks) with a thin extension.ts.
  • Centralizes constants (presentation-timing, sidebar-ui, evolution-battle, etc.).

Tests & quality

  • Sidebar tests (presenter, orchestrator, animation-host, provider).
  • Architecture boundary tests (architecture-boundary, hexagonal-boundary).
  • Expanded coverage for animations, usage pipeline, persistence, and Cursor adapters.
  • Biome formatting and consistent import grouping.

Documentation

  • Adds packages/cursor-vpet/docs/REFACTORING-IMPLEMENTATION-SPEC.md with the refactor plan and current status (~15% complete).

Commits

  1. refactor(cursor-vpet): add shared utilities and sqlite foundations
  2. refactor(cursor-vpet): isolate pure presentation under webview/presentation
  3. refactor(cursor-vpet): add VS Code ports and typed webview messages
  4. refactor(cursor-vpet): decompose sidebar into presenter and orchestrator
  5. refactor(cursor-vpet): modular bootstrap and thin extension entrypoint
  6. refactor(cursor-vpet): secure panels and move under webview/panels
  7. test(cursor-vpet): expand MonsterAnimationController coverage
  8. style(cursor-vpet): standardize import grouping order
  9. test(cursor-vpet): add sidebar and architecture boundary tests
  10. style(cursor-vpet): apply biome formatting
  11. refactor(cursor-vpet): centralize constants and expand test coverage

Test plan

  • bun run --filter cursor-vpet check
  • bun run --filter cursor-vpet test
  • bun run --filter cursor-vpet test:persistence
  • bun run --filter cursor-vpet build && bun run --filter cursor-vpet package
  • Sidebar: idle animation, evolution battle, and reveal with no regressions
  • Dex/History panels open and render correctly
  • Commands (spawn, freeze, hooks) still work
  • pet.db sync across extension windows remains intact

jcendal and others added 25 commits September 10, 2026 13:05
Extracts vpet-core as a shared package, moves the OpenCode plugin to
packages/opencode-vpet, and adds the cursor-vpet extension with its own
SQLite adapters and hooks. Updates CI/CD, workspaces, and monorepo documentation.

Co-authored-by: Cursor <cursoragent@cursor.com>
Adds walking, action, and sleep animation in the sidebar webview and copies
the root CHANGELOG.md when packing npm and VSIX artifacts, removing the local stub.

Co-authored-by: Cursor <cursoragent@cursor.com>
Calls nowMs as a function instead of passing unbound performance.now,
reorders partner sync after postMessage, and adds a regression test.

Co-authored-by: Cursor <cursoragent@cursor.com>
Converts pixel width to monospace columns based on the webview font so the
sprite fits without overflowing.

Co-authored-by: Cursor <cursoragent@cursor.com>
Rewrites the extension documentation with badges, guides, and usage sections,
and documents the author and contributor in the root README.

Co-authored-by: Cursor <cursoragent@cursor.com>
Colocates stage-changelog in each package, aligns the test fixture with the
monorepo layout, and fixes typecheck errors that blocked check.

Co-authored-by: Cursor <cursoragent@cursor.com>
…olds

Reuse the shared SQL.js runtime so the snapshot reader reloads the database
on each read instead of serving stale gauge values. Scale default evolution
thresholds 10× and document Open VSX publishing setup.

Co-authored-by: Cursor <cursoragent@cursor.com>
When a partner reaches a stage threshold, open a pending same-stage battle
instead of evolving immediately. Persist battle state in SQLite, notify via
toasts in OpenCode, and animate battles in the Cursor sidebar.

Co-authored-by: Cursor <cursoragent@cursor.com>
…nimations

Show a FIGlet BATTLE banner that blinks before combat, then play evolution or defeat animations based on the battle outcome.

Co-authored-by: Cursor <cursoragent@cursor.com>
Elimina el flag temporal, el comando de prueba y la lógica de preview automático para dejar solo el flujo real de batalla.

Co-authored-by: Cursor <cursoragent@cursor.com>
Reload sql.js state when pet.db changes on disk and watch the file so the sidebar stays fresh when multiple Cursor windows share the same ledger.

Co-authored-by: Cursor <cursoragent@cursor.com>
…oks.

Wire battle animations, session orchestration, and sidebar updates into the OpenCode TUI so evolution now requires winning a battle before advancing.

Co-authored-by: Cursor <cursoragent@cursor.com>
Use a single repository snapshot, a shared battle session, and refresh coalescing so pending battles resolve once instead of replaying in a loop.

Co-authored-by: Cursor <cursoragent@cursor.com>
Digitama now crosses stages in the database without a pending battle, while later stages keep the battle flow. Cursor queues direct-evolution reveals from usage events, and OpenCode runs battle and reveal presentations in the sidebar poll loop.

Co-authored-by: Cursor <cursoragent@cursor.com>
Centralize pure helpers (sleep, random, assertNever, async refresh queue),
deduplicate SQLite options/errors, import CompletedUsage from vpet-core,
and remove unused sqljs-runtime.

Co-authored-by: Cursor <cursoragent@cursor.com>
…tation

Move animation, artwork, and session modules into a VS Code-free folder
to separate visual logic from host-specific webview wiring.

Co-authored-by: Cursor <cursoragent@cursor.com>
Introduce notification, scheduler, and webview messenger adapters plus
discriminated union message parsing; wire provider through AnimationSink.

Co-authored-by: Cursor <cursoragent@cursor.com>
Split VpetSidebarProvider into pure presenter, animation host, and
orchestrator modules under webview/sidebar for single-responsibility.

Co-authored-by: Cursor <cursoragent@cursor.com>
Extract container wiring, command registration, sidebar setup, and usage
pipeline so extension.ts only orchestrates activation.

Co-authored-by: Cursor <cursoragent@cursor.com>
Escape HTML in Dex and History panels and relocate panel modules to
match the recommended folder structure.

Co-authored-by: Cursor <cursoragent@cursor.com>
Add exhaustive state-machine cases for walking, digitama, sleep, viewport, and activity transitions per architecture analysis.

Co-authored-by: Cursor <cursoragent@cursor.com>
Group imports as third-party, @sbugallo workspace packages, then relative paths across src and tests.

Co-authored-by: Cursor <cursoragent@cursor.com>
Cover sidebar orchestrator, animation host, and provider behavior with
fixtures and mocks so functional regressions are caught without changing
production code.

Co-authored-by: Cursor <cursoragent@cursor.com>
Normalize formatting across source and test files so biome ci passes.

Co-authored-by: Cursor <cursoragent@cursor.com>
Move repeated literals into shared/constants, add tsconfig.test.json so Bun
tests typecheck in the IDE, and cover game persistence, usage pipeline, and
domain evolution rules.

Co-authored-by: Cursor <cursoragent@cursor.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant