Update SQLite to version 3.53.3#98
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the vendored SQLite sources (amalgamation + headers + extensions) to SQLite 3.53.3, aligning CSQLite with the upstream release and pulling in upstream bugfixes and hardening changes.
Changes:
- Bumps embedded SQLite version metadata in
sqlite3.candsqlite3.hto 3.53.3. - Incorporates upstream fixes/hardening across pager/WAL, backup, URI parsing, FTS/RTREE, and various API mutex-protection changes.
- Updates bundled extensions (
series.c,decimal.c) with overflow/UBSAN-related fixes and rounding/parse boundary safety improvements.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| Sources/CSQLite/sqlite3.c | Replaces the SQLite amalgamation with upstream 3.53.3, including many correctness/security/concurrency fixes (and a few regressions to address). |
| Sources/CSQLite/series.c | Adds UBSAN-safe float-to-int64 conversion and tightens bound handling for series virtual table constraints. |
| Sources/CSQLite/include/sqlite3.h | Updates public header version identifiers and limit documentation to match 3.53.3. |
| Sources/CSQLite/decimal.c | Hardens decimal parsing against non-NUL-terminated inputs and improves rounding behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
226928
to
226932
| ofst = rbuDeltaGetInt(&zDelta, &lenDelta); | ||
| if( lenDelta>0 && zDelta[0]!=',' ){ | ||
| if( lenDelta>0 || zDelta[0]!=',' ){ | ||
| /* ERROR: copy command not terminated by ',' */ | ||
| return -1; | ||
| } |
Comment on lines
+151437
to
+151441
| pParse->nNestSel++; | ||
| #if SQLITE_MAX_EXPR_DEPTH>0 | ||
| if( pParse->nNestSel >= db->aLimit[SQLITE_LIMIT_EXPR_DEPTH] ){ | ||
| sqlite3ErrorMsg(pParse, "VIEWs and/or subqueries nested too deep"); | ||
| return 0; |
Comment on lines
151461
to
+151465
| @@ -151324,6 +151462,8 @@ SQLITE_PRIVATE Table *sqlite3ResultSetOfSelect(Parse *pParse, Select *pSelect, c | |||
| sqlite3DeleteTable(db, pTab); | |||
| return 0; | |||
| } | |||
| pParse->nNestSel--; | |||
Comment on lines
53029
to
+53031
| ** Return true if the string passed as the only argument is likely | ||
| ** to be a UNC path. In other words, if it starts with "\\". | ||
| ** to be a UNC path. Return false if note. | ||
| ** |
| ** a way that avoids 'outside the range of representable values' warnings | ||
| ** from UBSAN. | ||
| */ | ||
| sqlite3_int64 seriesRealToI64(double r){ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.