fix: wrap filter-pill event listener in DOMContentLoaded - #1130
Open
aditya226-sharma wants to merge 1 commit into
Open
fix: wrap filter-pill event listener in DOMContentLoaded#1130aditya226-sharma wants to merge 1 commit into
aditya226-sharma wants to merge 1 commit into
Conversation
The filter-pill click handler code ran immediately at script load time, before the DOM was ready, causing a console error when querySelectorAll found no matching elements. Wrapped in DOMContentLoaded to ensure elements exist before attaching listeners. Fixes sayeeg-11#1121
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The filter-pill click handler code ran immediately at script load time, before the DOM was ready, causing a console error when
querySelectorAllfound no matching elements. Wrapped inDOMContentLoadedto ensure elements exist before attaching listeners.Fixes #1121