Skip to content

updated rust pins - #71

Merged
joe-saronic merged 1 commit into
masterfrom
rustc-pin
Jul 27, 2026
Merged

updated rust pins#71
joe-saronic merged 1 commit into
masterfrom
rustc-pin

Conversation

@joe-saronic

@joe-saronic joe-saronic commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Rust version pinned in current flake will not build with binrw. We probably never noticed this because the broken cargo afl dependency would not let the default devshell run until #67 was fixed recently.

There is now a warning

warning: the following packages contain code that will be rejected by a future version of Rust: binrw v0.15.1

It is a known, well characterized issue that happened some time after rustc v1.95.0: jam1garner/binrw#366, rust-lang/rust#127909. It's been fixed upstream on master, just not released onto crates.io yet.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Nix flake Rust toolchain pinning to avoid recent build breakage related to binrw when using the previously pinned Rust, aligning the dev environment with a stable toolchain that should build successfully.

Changes:

  • Switch Rust toolchain selection in flake.nix from rust-bin.nightly.latest.default to rust-bin.stable.latest.default.
  • Update flake.lock to newer nixpkgs and rust-overlay revisions (and corresponding hashes/metadata).

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.

File Description
flake.nix Moves devshell/toolchain inputs from nightly to stable for cargo/rustc and the shell’s Rust package.
flake.lock Advances pinned nixpkgs/rust-overlay inputs to match the updated toolchain selection.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@joe-saronic
joe-saronic merged commit d7f6ebc into master Jul 27, 2026
1 check passed
@joe-saronic
joe-saronic deleted the rustc-pin branch July 27, 2026 16:17
@joe-saronic
joe-saronic restored the rustc-pin branch July 27, 2026 16:18
@joe-saronic
joe-saronic deleted the rustc-pin branch July 27, 2026 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants