Update numpy and sksparse changes - #124
Merged
ralberd merged 3 commits intoSep 21, 2026
Merged
Conversation
Numpy now returns complex numbers with 0 imaginary parts. Take real part to avoid problem. I'm not worried about speed here because this is only done once at the beginning of the simulation.
We're getting 14 significant figures correct.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #124 +/- ##
==========================================
+ Coverage 76.11% 76.19% +0.07%
==========================================
Files 67 67
Lines 5840 5830 -10
==========================================
- Hits 4445 4442 -3
+ Misses 1395 1388 -7 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
ralberd
approved these changes
Sep 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scikit sparse made API changes in v0.5. This keeps optimism up to date and building/running correctly out of the box. Also fixed failures due to small difference in behavior of numpy: roots of Legendre polynomial derivatives (used for locating quadrature points) are now reported as complex numbers with null imaginary parts, instead of reals. I adapted the code to this.