Repository navigation
fix(e2b): preserve domain boundaries with optional observations - #60
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Official E2B observations may omit
SandboxInfo.sandbox_domain, causing valid hosted environments to fail before their first Turn. Accept absent observation metadata without relaxing actual Create/Resume or saved-client connection checks. Keep a rejected bootstrap terminal even if a later observation omits the domain.This beta port includes explicit suspend/resume regression coverage: inspecting paused compute never calls connect; Resume retains the same sandbox and rejects invalid connection domains without replay.
Validation: 382 pinned-SDK helper tests passed, with fresh independent review. Production remains unchanged pending real managed lifecycle and preservation qualification. Main counterpart: #59.