ci: check against r-devel on windows as well as ubuntu - #31
Merged
Conversation
Windows plus r-devel is the pair CRAN's incoming check runs, and r-lib's standard matrix leaves it out, so it was the one combination nothing here covered. Running it in CI means a submission no longer depends on remembering to send a tarball to win-builder by hand.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
{ os: windows-latest, r: "devel" }to the R-CMD-check matrix.Why
Windows plus r-devel is the pair CRAN's own incoming check runs when a
tarball is submitted. r-lib's
examples/check-standard.yaml, which thismatrix was copied from, puts devel on ubuntu only, so that combination was
the one thing nothing here covered.
The gap was being filled by hand with
devtools::check_win_devel(), whichuploads a tarball to win-builder and emails the result back. That works, but
it depends on someone remembering to do it, and the result arrives somewhere
the repository cannot see. A matrix entry runs on every pull request instead.
Worth recording what this does not solve. The review comments CRAN raised
on a sibling package were about references in the Description field,
commented-out code in examples, and
Suggestsguards. None of those aremachine-detectable, and no amount of platform coverage would have caught
them. This closes a check-coverage gap, not a review-readiness one.
Not required for merge, deliberately
main's protection lists ten required checks by name, and the new jobreports as
R-CMD-check (windows-latest, devel), which is not among them. Itruns and reports without blocking.
That is the intended starting state. Windows r-devel is the least stable
square in the matrix, because CRAN's Windows r-devel binaries sometimes lag
and dependencies then build from source through Rtools. Making it required
immediately means an upstream hiccup blocks every merge, a release PR
included. Promote it once it has a track record.
Checks
The change is one matrix entry. The workflow parses, and
prek run --all-filesis clean.