Repository navigation
fix: prevent FE and BE from overwriting the build report - #50
Merged
Merged
Conversation
FE and BE both wrote .team/07-build.md, so parallel specialists could overwrite each other. Each now writes its own report and the orchestrator consolidates them only after every requested specialist succeeds. - fe -> .team/07-build-fe.md, be -> .team/07-build-be.md - orchestrator owns the consolidated .team/07-build.md - fail/cancel/missing specialist keeps the build stage incomplete - update team.yaml, /build, docs and generated reference - validate.rb rejects two agents writing the same .team artifact Refs #45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
fewrites.team/07-build-fe.md;bewrites.team/07-build-be.md. Neither writes the consolidated report..team/07-build.mdonly when all succeed. A failed, cancelled or missing specialist keeps the build stage incomplete.team.yaml,/build, README (EN/TR),docs/pipeline.md,docs/agents.md,team/AGENTS.md, theteam-buildskill and the generated command reference.scripts/validate.rbnow fails when two agent files instruct writes to the same.team/NN-*.mdartifact.Why
Both parallel build specialists wrote the same file, so one could overwrite the other's report. The static scan found no other duplicate writers: every other stage artifact has one writer, and the build report readers (QA, security, docs, devops, marketing) still read the consolidated file.
Verification
ruby scripts/validate.rb→ 47 files OKbash -n install.sh scripts/*.sh→ OK./scripts/smoke-install.sh→ smoke OKnpm run generate:reference→ current; onlydocs/reference/commands.mdchangedpwshunavailable); CI runs it onwindows-latestCloses #45