Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 12 additions & 12 deletions .github/workflows/ci-acp-sdk.yml
Original file line number Diff line number Diff line change
Expand Up @@ -64,18 +64,18 @@ jobs:
timeout-minutes: 15
steps:
- name: Checkout
uses: actions/checkout@fbc6f3992d24b796d5a048ff273f7fcc4a7b6c09 # v5.1.0
uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
with:
fetch-depth: 0
- name: Setup .NET
uses: actions/setup-dotnet@26b0ec14cb23fa6904739307f278c14f94c95bf1 # v5.4.0
uses: actions/setup-dotnet@a98b56852c35b8e3190ac28c8c2271da59106c68 # v6.0.0
with:
global-json-file: global.json
- name: Run the pinned upstream Agent against this SDK
run: bash scripts/gates/run-acp-official-v2-agent-gate.sh
- name: Upload upstream interoperability evidence
if: always()
uses: actions/upload-artifact@330a01c490aca151604b8cf639adc76d48f6c5d4 # v5.0.0
uses: actions/upload-artifact@cf430e030ddbb5b0abf93d22962f4752f3646cd9 # v7.0.2
with:
name: acp-official-v2-agent
path: |
Expand All @@ -94,18 +94,18 @@ jobs:
MSBUILDDISABLENODEREUSE: "1"
steps:
- name: Checkout
uses: actions/checkout@fbc6f3992d24b796d5a048ff273f7fcc4a7b6c09 # v5.1.0
uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
with:
fetch-depth: 0
- name: Setup .NET
uses: actions/setup-dotnet@26b0ec14cb23fa6904739307f278c14f94c95bf1 # v5.4.0
uses: actions/setup-dotnet@a98b56852c35b8e3190ac28c8c2271da59106c68 # v6.0.0
with:
global-json-file: global.json
- name: Verify real stdio batches without skips
run: bash scripts/gates/run-acp-batch-stdio-gate.sh Release
- name: Upload stdio evidence
if: always()
uses: actions/upload-artifact@330a01c490aca151604b8cf639adc76d48f6c5d4 # v5.0.0
uses: actions/upload-artifact@cf430e030ddbb5b0abf93d22962f4752f3646cd9 # v7.0.2
with:
name: acp-batch-stdio
path: artifacts/acp-batch-stdio/
Expand All @@ -119,12 +119,12 @@ jobs:
# history (tags included) must be present. A shallow clone would pack a 0.0.0-alpha version
# and the baseline guard in SalmonEgg.Acp.csproj would fail the pack.
- name: Checkout
uses: actions/checkout@fbc6f3992d24b796d5a048ff273f7fcc4a7b6c09 # v5.1.0
uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
with:
fetch-depth: 0

- name: Setup .NET
uses: actions/setup-dotnet@26b0ec14cb23fa6904739307f278c14f94c95bf1 # v5.4.0
uses: actions/setup-dotnet@a98b56852c35b8e3190ac28c8c2271da59106c68 # v6.0.0
with:
global-json-file: global.json

Expand All @@ -141,7 +141,7 @@ jobs:
run: ./scripts/gates/run-acp-sdk-tag-version-gate-selftest.sh

- name: Upload ACP SDK package
uses: actions/upload-artifact@330a01c490aca151604b8cf639adc76d48f6c5d4 # v5.0.0
uses: actions/upload-artifact@cf430e030ddbb5b0abf93d22962f4752f3646cd9 # v7.0.2
with:
name: acp-sdk-package
path: "${{ env.PACKAGE_OUTPUT }}/*.nupkg"
Expand All @@ -153,15 +153,15 @@ jobs:
timeout-minutes: 25
steps:
- name: Checkout
uses: actions/checkout@fbc6f3992d24b796d5a048ff273f7fcc4a7b6c09 # v5.1.0
uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1

- name: Setup .NET
uses: actions/setup-dotnet@26b0ec14cb23fa6904739307f278c14f94c95bf1 # v5.4.0
uses: actions/setup-dotnet@a98b56852c35b8e3190ac28c8c2271da59106c68 # v6.0.0
with:
global-json-file: global.json

- name: Download ACP SDK package
uses: actions/download-artifact@634f93cb2916e3fdff6788551b99b062d0335ce0 # v5.0.0
uses: actions/download-artifact@9000827ccba6bdab643e8b6fd33ac0654aef8333 # v8.0.2
with:
name: acp-sdk-package
path: artifacts/acp-sdk-package
Expand Down
18 changes: 9 additions & 9 deletions .github/workflows/ci-core.yml
Original file line number Diff line number Diff line change
Expand Up @@ -53,11 +53,11 @@ jobs:
MSBUILDDISABLENODEREUSE: "1"
steps:
- name: Checkout
uses: actions/checkout@fbc6f3992d24b796d5a048ff273f7fcc4a7b6c09 # v5.1.0
uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
with:
fetch-depth: 0
- name: Setup .NET
uses: actions/setup-dotnet@26b0ec14cb23fa6904739307f278c14f94c95bf1 # v5.4.0
uses: actions/setup-dotnet@a98b56852c35b8e3190ac28c8c2271da59106c68 # v6.0.0
with:
global-json-file: global.json
- name: Verify real cancellation transports without skips
Expand All @@ -68,11 +68,11 @@ jobs:
shell: bash
run: |
python3 -m venv "$RUNNER_TEMP/acp-bridge-venv"
"$RUNNER_TEMP/acp-bridge-venv/bin/pip" install acpremote==1.9.0
"$RUNNER_TEMP/acp-bridge-venv/bin/pip" install acpremote==1.10.0

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Pin acpremote to an available release

acpremote==1.10.0 is not published on PyPI—the project's release history currently ends at 1.9.0—so this pip install fails before the published-bridge cancellation gate can run on every CI invocation. Pin this back to an existing release (or publish/configure the intended index) so the required transport validation remains executable. PyPI release history

Useful? React with 👍 / 👎.

python3 scripts/gates/run-acp-published-bridge-gate.py --bridge "$RUNNER_TEMP/acp-bridge-venv/bin/acpremote"
- name: Upload transport evidence
if: always()
uses: actions/upload-artifact@330a01c490aca151604b8cf639adc76d48f6c5d4 # v5.0.0
uses: actions/upload-artifact@cf430e030ddbb5b0abf93d22962f4752f3646cd9 # v7.0.2
with:
name: acp-cancellation-transports
path: |
Expand All @@ -86,12 +86,12 @@ jobs:
timeout-minutes: 45
steps:
- name: Checkout
uses: actions/checkout@fbc6f3992d24b796d5a048ff273f7fcc4a7b6c09 # v5.1.0
uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
with:
fetch-depth: 0

- name: Setup .NET
uses: actions/setup-dotnet@26b0ec14cb23fa6904739307f278c14f94c95bf1 # v5.4.0
uses: actions/setup-dotnet@a98b56852c35b8e3190ac28c8c2271da59106c68 # v6.0.0
with:
global-json-file: global.json

Expand Down Expand Up @@ -173,14 +173,14 @@ jobs:

- name: Upload test results
if: always()
uses: actions/upload-artifact@330a01c490aca151604b8cf639adc76d48f6c5d4 # v5.0.0
uses: actions/upload-artifact@cf430e030ddbb5b0abf93d22962f4752f3646cd9 # v7.0.2
with:
name: test-results
path: "${{ env.TEST_RESULTS_DIR }}/**/*.trx"

- name: Upload coverage reports
if: always()
uses: actions/upload-artifact@330a01c490aca151604b8cf639adc76d48f6c5d4 # v5.0.0
uses: actions/upload-artifact@cf430e030ddbb5b0abf93d22962f4752f3646cd9 # v7.0.2
with:
name: coverage-report
path: "**/coverage*.xml"
Expand All @@ -196,7 +196,7 @@ jobs:
timeout-minutes: 10
steps:
- name: Checkout
uses: actions/checkout@fbc6f3992d24b796d5a048ff273f7fcc4a7b6c09 # v5.1.0
uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
with:
fetch-depth: 1
persist-credentials: false
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/code-quality.yml
Original file line number Diff line number Diff line change
Expand Up @@ -48,12 +48,12 @@ jobs:
timeout-minutes: 30
steps:
- name: Checkout
uses: actions/checkout@fbc6f3992d24b796d5a048ff273f7fcc4a7b6c09 # v5.1.0
uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
with:
fetch-depth: 0

- name: Setup .NET
uses: actions/setup-dotnet@26b0ec14cb23fa6904739307f278c14f94c95bf1 # v5.4.0
uses: actions/setup-dotnet@a98b56852c35b8e3190ac28c8c2271da59106c68 # v6.0.0
with:
global-json-file: global.json

Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/codeql.yml
Original file line number Diff line number Diff line change
Expand Up @@ -52,15 +52,15 @@ jobs:
contents: read
steps:
- name: Checkout
uses: actions/checkout@fbc6f3992d24b796d5a048ff273f7fcc4a7b6c09 # v5.1.0
uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1

- name: Setup .NET
uses: actions/setup-dotnet@26b0ec14cb23fa6904739307f278c14f94c95bf1 # v5.4.0
uses: actions/setup-dotnet@a98b56852c35b8e3190ac28c8c2271da59106c68 # v6.0.0
with:
global-json-file: global.json

- name: Initialize CodeQL
uses: github/codeql-action/init@42947a340483f03ba47bb1a039b2c519aab3df85 # v3.37.8
uses: github/codeql-action/init@2892aa5e19bbd11bc0cff5427e3b750a04d9e3c2 # v4.38.2
with:
languages: csharp
build-mode: manual
Expand Down Expand Up @@ -97,6 +97,6 @@ jobs:
done

- name: Perform CodeQL Analysis
uses: github/codeql-action/analyze@42947a340483f03ba47bb1a039b2c519aab3df85 # v3.37.8
uses: github/codeql-action/analyze@2892aa5e19bbd11bc0cff5427e3b750a04d9e3c2 # v4.38.2
with:
category: "/language:csharp"
12 changes: 6 additions & 6 deletions .github/workflows/gui-smoke-gates.yml
Original file line number Diff line number Diff line change
Expand Up @@ -49,10 +49,10 @@ jobs:
timeout-minutes: 45
steps:
- name: Checkout
uses: actions/checkout@fbc6f3992d24b796d5a048ff273f7fcc4a7b6c09 # v5.1.0
uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1

- name: Setup .NET
uses: actions/setup-dotnet@26b0ec14cb23fa6904739307f278c14f94c95bf1 # v5.4.0
uses: actions/setup-dotnet@a98b56852c35b8e3190ac28c8c2271da59106c68 # v6.0.0
with:
global-json-file: global.json

Expand All @@ -79,7 +79,7 @@ jobs:

- name: Upload ACP setup path evidence
if: always()
uses: actions/upload-artifact@330a01c490aca151604b8cf639adc76d48f6c5d4 # v5.0.0
uses: actions/upload-artifact@cf430e030ddbb5b0abf93d22962f4752f3646cd9 # v7.0.2
with:
name: acp-setup-path-smoke
path: ${{ runner.temp }}/acp-setup-path-smoke
Expand All @@ -97,7 +97,7 @@ jobs:

- name: Upload native elicitation evidence
if: always()
uses: actions/upload-artifact@330a01c490aca151604b8cf639adc76d48f6c5d4 # v5.0.0
uses: actions/upload-artifact@cf430e030ddbb5b0abf93d22962f4752f3646cd9 # v7.0.2
with:
name: native-elicitation-consent
path: |
Expand Down Expand Up @@ -135,10 +135,10 @@ jobs:
if: github.event_name == 'workflow_dispatch' && vars.WINDOWS_GUI_SELF_HOSTED_RUNNER == 'true'
steps:
- name: Checkout
uses: actions/checkout@fbc6f3992d24b796d5a048ff273f7fcc4a7b6c09 # v5.1.0
uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1

- name: Setup .NET
uses: actions/setup-dotnet@26b0ec14cb23fa6904739307f278c14f94c95bf1 # v5.4.0
uses: actions/setup-dotnet@a98b56852c35b8e3190ac28c8c2271da59106c68 # v6.0.0
with:
global-json-file: global.json

Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/macos-native-acceptance.yml
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ jobs:
UseSharedCompilation: 'false'
steps:
- name: Checkout
uses: actions/checkout@fbc6f3992d24b796d5a048ff273f7fcc4a7b6c09 # v5.1.0
uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
with:
fetch-depth: 0
- name: Verify native observation readiness contracts
Expand All @@ -45,7 +45,7 @@ jobs:
timeout-minutes: 3
run: python3 scripts/gates/run-macos-desktop-input-probe.py
- name: Setup .NET
uses: actions/setup-dotnet@26b0ec14cb23fa6904739307f278c14f94c95bf1 # v5.4.0
uses: actions/setup-dotnet@a98b56852c35b8e3190ac28c8c2271da59106c68 # v6.0.0
with:
global-json-file: global.json
- name: Build the current native macOS application
Expand All @@ -62,7 +62,7 @@ jobs:
run: python3 scripts/gates/macos-elicitation-reverse-verification.py
- name: Upload native desktop evidence
if: always()
uses: actions/upload-artifact@330a01c490aca151604b8cf639adc76d48f6c5d4 # v5.0.0
uses: actions/upload-artifact@cf430e030ddbb5b0abf93d22962f4752f3646cd9 # v7.0.2
with:
name: macos-native-desktop-input
path: |
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/native-android-acceptance.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,12 +38,12 @@ jobs:
SALMONEGG_ANDROID_REVERSE: ${{ github.event_name == 'workflow_dispatch' && inputs.reverse-verification || false }}
steps:
- name: Checkout
uses: actions/checkout@fbc6f3992d24b796d5a048ff273f7fcc4a7b6c09 # v5.1.0
uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
with:
fetch-depth: 0

- name: Setup .NET
uses: actions/setup-dotnet@26b0ec14cb23fa6904739307f278c14f94c95bf1 # v5.4.0
uses: actions/setup-dotnet@a98b56852c35b8e3190ac28c8c2271da59106c68 # v6.0.0
with:
global-json-file: global.json

Expand All @@ -57,7 +57,7 @@ jobs:
'platforms;android-36' 'build-tools;36.0.0' platform-tools emulator 'system-images;android-36;google_apis;x86_64'
echo "$ANDROID_SDK_ROOT/platform-tools" >> "$GITHUB_PATH"
python3 -m venv "$RUNNER_TEMP/android-acp-tools"
"$RUNNER_TEMP/android-acp-tools/bin/python" -m pip install aiohttp==3.12.15
"$RUNNER_TEMP/android-acp-tools/bin/python" -m pip install aiohttp==3.14.4

- name: Build current installable APK
run: |
Expand Down Expand Up @@ -133,7 +133,7 @@ jobs:

- name: Upload acceptance evidence
if: always()
uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 # v4.6.2
uses: actions/upload-artifact@cf430e030ddbb5b0abf93d22962f4752f3646cd9 # v7.0.2
with:
name: android-installed-acp-acceptance
path: artifacts/android-acp-acceptance
Expand Down
21 changes: 11 additions & 10 deletions .github/workflows/native-ios-acceptance.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,37 +29,37 @@ concurrency:
jobs:
installed-ios:
name: iOS Installed ACP UI
# Pair the repository's .NET 10 SDK with the published 10.0.300.3 Apple workload set.
# Xcode 26.5 / iOS 26.5 are both installed on this serviced native host.
# Pin the 10.0.401 workload set: its Apple workload (26.5.10318) requires Xcode 26.6, which this GA
# image carries. The band's later 10.0.401.1 set moves to Xcode 27, whose hosted image is a preview.
runs-on: macos-26
timeout-minutes: ${{ github.event_name == 'workflow_dispatch' && inputs.reverse-verification && 65 || 35 }}
timeout-minutes: ${{ github.event_name == 'workflow_dispatch' && inputs.reverse-verification && 80 || 35 }}
env:
DOTNET_PROCESSOR_COUNT: 2
DOTNET_CLI_USE_MSBUILD_SERVER: 0
MSBUILDDISABLENODEREUSE: 1
steps:
- name: Checkout
uses: actions/checkout@fbc6f3992d24b796d5a048ff273f7fcc4a7b6c09 # v5.1.0
uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
with:
fetch-depth: 0

- name: Setup .NET
uses: actions/setup-dotnet@26b0ec14cb23fa6904739307f278c14f94c95bf1 # v5.4.0
uses: actions/setup-dotnet@a98b56852c35b8e3190ac28c8c2271da59106c68 # v6.0.0
with:
global-json-file: global.json

- name: Select matching Apple toolchain
run: |
xcode_developer_dir="$(python3 -c 'import os; print(os.path.realpath("/Applications/Xcode_26.5.app/Contents/Developer"))')"
xcode_developer_dir="$(python3 -c 'import os; print(os.path.realpath("/Applications/Xcode_26.6.app/Contents/Developer"))')"
test -d "$xcode_developer_dir"
sudo xcode-select --switch "$xcode_developer_dir"
xcodebuild -version
sw_vers
uname -m
xcrun --sdk iphonesimulator --show-sdk-path
xcrun --sdk macosx --find actool
# https://github.com/dotnet/macios/releases/tag/dotnet-10.0.1xx-xcode26.5-10284
dotnet workload install ios --version 10.0.300.3 --disable-parallel --no-http-cache
# https://github.com/dotnet/macios/releases/tag/dotnet-10.0.1xx-xcode26.5-10318
dotnet workload install ios --version 10.0.401 --disable-parallel --no-http-cache
dotnet workload list
# Wait for CoreSimulatorService before actool / xcodebuild (runner-images #12777).
xcrun simctl list runtimes
Expand All @@ -77,7 +77,7 @@ jobs:
- name: Install isolated test tooling
run: |
python3 -m venv "$RUNNER_TEMP/ios-acp-tools"
"$RUNNER_TEMP/ios-acp-tools/bin/python" -m pip install aiohttp==3.12.15
"$RUNNER_TEMP/ios-acp-tools/bin/python" -m pip install aiohttp==3.14.4
curl --location --fail --silent --show-error \
https://github.com/yonaskolb/XcodeGen/releases/download/2.46.0/xcodegen.zip \
--output "$RUNNER_TEMP/xcodegen.zip"
Expand All @@ -100,7 +100,7 @@ jobs:

- name: Upload acceptance evidence
if: always()
uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 # v4.6.2
uses: actions/upload-artifact@cf430e030ddbb5b0abf93d22962f4752f3646cd9 # v7.0.2
with:
name: ios-installed-acp-acceptance
path: |
Expand All @@ -109,6 +109,7 @@ jobs:
artifacts/ios-acp-acceptance/product-logs/**
artifacts/ios-acp-acceptance/results.xcresult
artifacts/ios-acp-acceptance/test-attachments/**
artifacts/ios-acp-acceptance/hang-diagnostics/**
artifacts/ios-acp-acceptance/reverse/*.json
artifacts/ios-acp-acceptance/reverse/*.log
artifacts/ios-acp-acceptance/reverse/red/*.json
Expand Down
Loading
Loading