Skip to content

fix: crash in Button's deprecated tooltip prop caused by an unbound render function - #3191

Open
zigzagdev wants to merge 1 commit into
salesforce:masterfrom
zigzagdev:fix/button-tooltip-render
Open

fix: crash in Button's deprecated tooltip prop caused by an unbound render function#3191
zigzagdev wants to merge 1 commit into
salesforce:masterfrom
zigzagdev:fix/button-tooltip-render

Conversation

@zigzagdev

@zigzagdev zigzagdev commented Aug 28, 2026 •
edited
Loading

Copy link
Copy Markdown

Fixes #

This PR fixes a one-line bug in renderTooltip in components/button/index.jsx, and adds a regression test in components/button/__tests__/button.browser-test.jsx to prevent it from recurring.

Additional description

CONTRIBUTOR checklist (do not remove)

Please complete for every pull request

  • First-time contributors should sign the Contributor License Agreement. It's a fancy way of saying that you are giving away your contribution to this project. If you haven't before, wait a few minutes and a bot will comment on this pull request with instructions.
  • npm run lint:fix has been run and linting passes.
  • Mocha, Jest (Storyshots), and components/component-docs.json CI tests pass (npm test).
  • Tests have been added for new props to prevent regressions in the future. See readme.
  • Review the appropriate Storybook stories. Open http://localhost:9001/.
  • Review tests are passing in the browser. Open http://localhost:8001/.
  • Review markup conforms to SLDS by looking at DOM snapshot strings.

REVIEWER checklist (do not remove)

  • CircleCI tests pass. This includes linting, Mocha, Jest, Storyshots, and components/component-docs.json tests.
  • Tests have been added for new props to prevent regressions in the future. See readme.
  • Review the appropriate Storybook stories. Open http://localhost:9001/.
  • The Accessibility panel of each Storybook story has 0 violations (aXe). Open http://localhost:9001/.
  • Review tests are passing in the browser. Open http://localhost:8001/.
  • Review markup conforms to SLDS by looking at DOM snapshot strings.
Required only if there are markup / UX changes
  • Add year-first date and commit SHA to last-slds-markup-review in package.json and push.
  • Request a review of the deployed Heroku app by the Salesforce UX Accessibility Team.
  • Add year-first review date, and commit SHA, last-accessibility-review, to package.json and push.
  • While the contributor's branch is checked out, run npm run local-update within locally cloned site repo to confirm the site will function correctly at the next release.

@salesforce-cla

salesforce-cla Bot commented Aug 28, 2026

Copy link
Copy Markdown

Thanks for the contribution! Before we can merge this, we need @zigzagdev to sign the Salesforce Inc. Contributor License Agreement.

@zigzagdev
zigzagdev marked this pull request as draft August 28, 2026 14:47
@zigzagdev
Fix Button crash when using deprecated tooltip prop
f86172e 
renderTooltip passed the unbound this.renderButton function reference
as Tooltip's children instead of invoking it, causing Tooltip to clone
a non-element and throw.
@zigzagdev
zigzagdev force-pushed the fix/button-tooltip-render branch from 2edf90c to f86172e Compare August 28, 2026 14:48
@zigzagdev
zigzagdev marked this pull request as ready for review August 28, 2026 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

cla:signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@zigzagdev