Fix dead test-coverage CI job - #165
Merged
Merged
Conversation
actions/upload-artifact@v3 is deprecated and GitHub now hard-rejects any workflow run using it, so the test-coverage job was failing instantly on every push/PR regardless of the R package's actual state. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
11 of 15 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test-coverage.yamlwas failing instantly (~2s) on every push/PR because it usesactions/upload-artifact@v3, which GitHub has deprecated and now hard-rejects at the API level (see https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/). This was unrelated to the actual package state — it failed the same way on old, already-merged commits.Changes
actions/upload-artifact@v3->@v4in the "Upload test results" step.Note
While investigating CI health for the visreg 3.0 CRAN fix (PR #164), I also found the AppVeyor status checks (
continuous-integration/appveyor/branchand/pr) fail instantly with no jobs. There's noappveyor.ymlin this repo, so that integration isn't controllable from here — it looks like an orphaned external project setting (not referenced anywhere in-repo, e.g. no badge in README). Since GH Actions'windows-latestjob incheck-standard.yamlalready covers Windows checks, you may want to just disable the AppVeyor integration from its own dashboard rather than reintroduce anappveyor.yml.🤖 Generated with Claude Code