Repository navigation
fix: keep callback userdata valid across moves - #693
Open
dajiaohuang wants to merge 1 commit into
Open
dajiaohuang wants to merge 1 commit into
dajiaohuang wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #691.
Easy2::default_configurepreviously derived libcurl callback userdata by casting a shared reference toInnerinto a mutable pointer. The callback later mutates the handler through that pointer, and the stored pointer can also outlive the temporary borrow and be invalidated asEasy2moves.Keep
Innerin an owning raw-pointer wrapper created withBox::into_raw, and pass that allocation pointer to libcurl callbacks. The wrapper provides the existing field access and reconstructs theBoxon drop, aftercurl_easy_cleanuphas run. Add a synthetic callback regression that moves the owner and invokes the write callback through the saved userdata.Validation:
cargo test --offline --package curl --lib --no-default-features— 6 passed.rustfmt --check --edition 2018 src/easy/handler.rs— passed.git diff --check— passed.