Skip to content

Restore Windows SSPI for the rustls and windows-static-ssl backends #667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ns-ylambert wants to merge 2 commits into
base: main
Choose a base branch
from
+29 −18
Open

Restore Windows SSPI for the rustls and windows-static-ssl backends #667

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
925a4ba
curl-sys: fix spnego + rustls compile error on Windows
ns-ylambert Sep 30, 2026
e18f765
curl-sys: compile Windows SSPI in the rustls/windows-static-ssl branches
ns-ylambert Sep 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 29 additions & 18 deletions curl-sys/build.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -342,12 +342,6 @@ fn main() {
cfg.include(path);
}

if cfg!(feature = "spnego") {
cfg.define("USE_SPNEGO", None)
.file("curl/lib/http_negotiate.c")
.file("curl/lib/vauth/vauth.c");
}

// Configure TLS backend. Since Cargo does not support mutually exclusive
// features, make sure we only compile one vtls.
if cfg!(feature = "rustls") {
Expand Down Expand Up @@ -380,14 +374,7 @@ fn main() {
if windows {
// For windows, spnego feature is auto on in case ssl feature is on.
// Please see definition of USE_SPNEGO in curl_setup.h for more info.
cfg.define("USE_WINDOWS_SSPI", None)
.define("USE_SCHANNEL", None)
.file("curl/lib/http_negotiate.c")
.file("curl/lib/curl_sspi.c")
.file("curl/lib/socks_sspi.c")
.file("curl/lib/vauth/krb5_sspi.c")
.file("curl/lib/vauth/spnego_sspi.c")
.file("curl/lib/vauth/vauth.c")
cfg.define("USE_SCHANNEL", None)
.file("curl/lib/vtls/schannel.c")
.file("curl/lib/vtls/schannel_verify.c")
.file("curl/lib/vtls/x509asn1.c");
Expand All @@ -407,6 +394,34 @@ fn main() {
}
}

// Compile Windows SSPI alongside any TLS backend so libcurl's integrated
// Windows authentication (NTLM/Negotiate) stays available.
// `USE_WINDOWS_SSPI` unconditionally triggers `USE_SPNEGO` in
// `curl_setup.h`, which causes `http.c` (always compiled) to reference
// symbols from `http_negotiate.c` and `spnego_sspi.c`. Those files must
// therefore be compiled whenever `windows_sspi` is true, regardless of
// whether the `spnego` cargo feature was explicitly requested.
let windows_sspi = windows
&& cfg!(any(
feature = "ssl",
feature = "rustls",
feature = "windows-static-ssl"
));

if !windows && cfg!(feature = "spnego") {
cfg.define("USE_SPNEGO", None);
}
if windows_sspi || cfg!(feature = "spnego") {
cfg.file("curl/lib/http_negotiate.c");
}
if windows_sspi {
cfg.define("USE_WINDOWS_SSPI", None)
.file("curl/lib/curl_sspi.c")
.file("curl/lib/socks_sspi.c")
.file("curl/lib/vauth/krb5_sspi.c")
.file("curl/lib/vauth/spnego_sspi.c");
}

// Configure platform-specific details.
if windows {
cfg.define("HAVE_CONFIG_H", None)
Expand All @@ -421,10 +436,6 @@ fn main() {
.file("curl/lib/curlx/multibyte.c")
.file("curl/lib/curlx/version_win32.c")
.file("curl/lib/curlx/winapi.c");

if cfg!(feature = "spnego") {
cfg.file("curl/lib/vauth/spnego_sspi.c");
}
} else {
cfg.define("RECV_TYPE_ARG1", "int")
.define("HAVE_PTHREAD_H", None)
Expand Down
Loading