Repository navigation
Conversation
The formatting toolbar of the clip edit window had no tooltips, so buttons like W (word wrap) or the indent buttons were hard to tell apart. The top toolbar of the same window already has them. - The toolbar is created with TBSTYLE_TOOLTIPS, so it registers every button with its tooltip and relays the mouse itself; the editor only sets the texts, also when the toolbar is recreated after a DPI change. - The font name and size combos and the color picker, which sit over toolbar separators, get their own tools. The toolbar does not relay mouse messages of its child windows, so these tools are added with TTF_SUBCLASS (CToolTipCtrl::AddTool does not set it). - Shortcuts handled by the editor are shown the same way as on the top toolbar: Ctrl - B / I / U and Ctrl - W. - New strings in English.xml, with Russian and Ukrainian translations.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The formatting toolbar of the clip edit window has no tooltips, so some buttons are hard to tell apart: W (word wrap) for example, or the two indent buttons. The top toolbar of the same window already shows tooltips with shortcuts.
Changes
CRRECToolbaris created withTBSTYLE_TOOLTIPS. The toolbar registers every button with its tooltip and relays the mouse itself;CRulerRichEditCtrl::CreateToolbaronly sets the texts.CreateToolbaralso runs when the toolbar is recreated after a DPI change, so the tooltips come back with it.TTF_SUBCLASSthroughTTM_ADDTOOL(CToolTipCtrl::AddTooldoes not set that flag).CRulerRichEditCtrl::PreTranslateMessageare shown the same way as on the top toolbar:Ctrl - B,Ctrl - I,Ctrl - U,Ctrl - W.English.xml(EditToolbar*), with Russian and Ukrainian translations.Testing
MSBuild CP_Main_10.sln /p:Configuration=Release /p:Platform=x64.