FileWriter stats - #205
Merged
Merged
Conversation
Member
|
I still don't fully understand why you don't want to clear stats also in sabctools? |
Contributor
Author
|
It doesn't make a whole lot of difference on the Sab side, but I don't think we are ever going to need more than one consumer so switched it to C having a reset option. But I suppose getting each read with reset naturally only covering that window is simpler to consume. Not relevant now but overflow is not a risk, at 10 Gbps it'd take >450 years. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sabctools.write_stats()returns totals for every write through everyFileWriter: count, bytes, nanoseconds spent inside the write, and the slowest single write.The per-architecture vendored builds no longer inherit universal2
-archflags, which made CMake reject each slice before compiling anything - build issue caused bybuild_macospassingCFLAGS(nothing wrong with existing wheels)