Skip to content

FileWriter stats - #205

Merged
Safihre merged 6 commits into
sabnzbd:masterfrom
mnightingale:feature/storage_probe
Aug 27, 2026
Merged

FileWriter stats#205
Safihre merged 6 commits into
sabnzbd:masterfrom
mnightingale:feature/storage_probe

Conversation

@mnightingale

@mnightingale mnightingale commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

sabctools.write_stats() returns totals for every write through every FileWriter: count, bytes, nanoseconds spent inside the write, and the slowest single write.

The per-architecture vendored builds no longer inherit universal2 -arch flags, which made CMake reject each slice before compiling anything - build issue caused by build_macos passing CFLAGS (nothing wrong with existing wheels)

@Safihre

Safihre commented Aug 27, 2026

Copy link
Copy Markdown
Member

I still don't fully understand why you don't want to clear stats also in sabctools?
And is there no risk of integer overflow in case somebody keeps SAB running for months?

@mnightingale

Copy link
Copy Markdown
Contributor Author

It doesn't make a whole lot of difference on the Sab side, but I don't think we are ever going to need more than one consumer so switched it to C having a reset option. But I suppose getting each read with reset naturally only covering that window is simpler to consume.

Not relevant now but overflow is not a risk, at 10 Gbps it'd take >450 years.

@Safihre
Safihre merged commit c3a1710 into sabnzbd:master Aug 27, 2026
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants