[codex] Fix web jump image updates#4
Draft
mickaelbegon wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the web behavior where selecting a different jump updated the numeric values but did not reliably update the displayed jump image.
Root Cause
Changing the selected jump calls
Biomechanics.setValues(...)to reset the model. One field,_finalInertia, was declared aslate final, so the second assignment raised aLateInitializationError. In the web app this interrupted the jump-change flow and left the UI in a partially updated state.The image widget also had no asset-specific identity, so the background image replacement relied on Flutter reusing and updating the existing widget correctly.
Changes
finalInertiamutable like the other editable biomechanics values, allowing jump changes to reset the full model.Image.assetwith the selected asset path so the visible image follows the selected jump.web/index.htmlto use the current Flutter web bootstrap script.Validation
flutter testpassed: 14 testsflutter analyzepassed with no issuesflutter build web --releasesucceededhttp://localhost:60205/#/jump-screen: Axel, Lutz, and Somersault all switch images and values without new console errorsNote: test the web app through an HTTP server URL, not by opening
web/index.htmldirectly withfile://, because Flutter web assets/bootstrap are served differently.