Outline reserve slow paths#5
Open
charliermarsh wants to merge 1 commit into
Open
Conversation
Owner
|
Thank you for the PR and the benchmark results. They look very promising. This might be a bit of a personal preference, but I'd like to check the |
Contributor
Author
|
Take your time or even feel free to reject it if you prefer, no pressure. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
reservecurrently carries allocation and copy-on-write logic even when a string already has enough capacity. This moves those uncommon cases into separate functions, making common append and reserve operations faster without changing behavior.Local Apple arm64 benchmarks showed improvements of 7–29% across the measured append paths, with about a 0.2% increase in code size. The benchmark suite is maintained separately and is not included in this PR.