Repository navigation
docs(protocol): name destructive commands 155-159 (certificate transfer, LOCK_DEVICE) - #2828
Open
LeonardSEO wants to merge 1 commit into
Open
LeonardSEO wants to merge 1 commit into
LeonardSEO wants to merge 1 commit into
Conversation
… for log legibility Names from the official app's command table via LeonardSEO/wearable5.0. Schema and Kotlin name map only; listed as destructive and absent from the send allowlist on both platforms.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Names five opcodes from the official app 5.473.0 in the shared schema (
whoop_protocol.json) and the KotlinCommandNamesmap, so a response echoing one is legible in a strap log:START_CERTIFICATE_TRANSFERLOAD_CERTIFICATEVERIFY_CERTIFICATEPROCESS_CERTIFICATELOCK_DEVICEAll five are destructive or of unknown reversibility. They are added to the "Destructive commands" table in
docs/PROTOCOL_IMPLEMENTATION.mdand stay out of the send allowlist and sender enums on both platforms. Nothing can send them.146/147 (SET_CLOCK / GET_CLOCK in the app's table) are left out on purpose: those names already belong to 10/11 in NOOP's schema and would make logs ambiguous.
Source: LeonardSEO/wearable5.0, command table (app-derived names).
Type of change
How it was tested
CommandCatalogueTest(schema and Kotlin name map stay in lockstep) passes with the five new names.swift testinPackages/WhoopProtocol: 816 tests pass (1 skipped, as onmain)../gradlew testFullDebugUnitTest: 6688 tests, all pass apart from the 2RecoveryDriversTesthalf-tie cases that fail the same way on unmodifiedmain.Tools/i18n_audit.py --ci,Tools/doc_comment_lint.py,docs/protocol-exampleschecks andTools/parity_ledger.py --refresh-derived(derived snapshots included): pass.Toolsunit tests, the parity acceptance suite and the R-R contract: pass apart from the 4test_check_source_referencescases (/varvs/private/vartemp path on macOS) that fail the same way on unmodifiedmain.Strand) builds with this change on my development branch;StrandTestsand the iOS target were not run locally for this branch.app-build.ymlcovers both.Checklist
android/(apart from the 2RecoveryDriversTesthalf-tie cases that fail the same way on unmodifiedmain)StrandDesign/Palette/Metricstokensdocs/CONTRIBUTING.mdStrand.xcodeproj/) or any secrets/keystoresRelated issues
None.
🤖 Generated with Claude Code