Repository navigation
fix(copy): describe a 5/MG offload that served no history instead of calling sync experimental - #2827
Open
LeonardSEO wants to merge 1 commit into
Open
LeonardSEO wants to merge 1 commit into
LeonardSEO wants to merge 1 commit into
Conversation
…tory sync experimental The history chip now states the observed fact, and the Android add-device note uses the text and translations Apple already ships. Copy only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Copy only; no behaviour changes.
historySyncExperimentalstate (Effort vs Charge graph on homepage #580) is shown when a 5/MG acked SEND_HISTORICAL_DATA but served no type-47 records. It said "History sync is experimental on 5.0". It now says what happened: "The last sync brought no history from this 5.0 strap." (Apple, Android, all locales).The 5/MG alarm caveat and every strap-writing probe keep their warnings.
Context: the 5/MG history framing (HISTORY_START / END / COMPLETE, the 8-byte END token, ACK construction) was checked byte-exact on public captures in LeonardSEO/wearable5.0 (FINDINGS status table). #2795 also edits 5/MG copy; this PR touches different strings, but the two may need a rebase against each other.
Type of change
How it was tested
./gradlew testFullDebugUnitTest: 6688 tests, all pass apart from the 2RecoveryDriversTesthalf-tie cases that fail the same way on unmodifiedmain.Tools/i18n_audit.py --ci,Tools/doc_comment_lint.py,docs/protocol-exampleschecks andTools/parity_ledger.py --refresh-derived(derived snapshots included): pass.Toolsunit tests, the parity acceptance suite and the R-R contract: pass apart from the 4test_check_source_referencescases (/varvs/private/vartemp path on macOS) that fail the same way on unmodifiedmain.Strand) builds with this change on my development branch;StrandTestsand the iOS target were not run locally for this branch.app-build.ymlcovers both.Checklist
android/(apart from the 2RecoveryDriversTesthalf-tie cases that fail the same way on unmodifiedmain)StrandDesign/Palette/Metricstokensdocs/CONTRIBUTING.mdStrand.xcodeproj/) or any secrets/keystoresRelated issues
None.
🤖 Generated with Claude Code