Repository navigation
feat(spo2): show the 5/MG SpO2 strap reading by default (experimental, not expected to merge) - #2826
Open
LeonardSEO wants to merge 1 commit into
Open
LeonardSEO wants to merge 1 commit into
LeonardSEO wants to merge 1 commit into
Conversation
The strap computes the value itself (LeonardSEO/wearable5.0 FINDINGS §13). Still never written to spo2Pct and never scored; an explicit off still wins. Refs ryanbr#103
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Experimental, and I do not expect this one to be accepted: it turns on by default a value the project deliberately keeps behind a default-off toggle until cross-device evidence agrees. I am opening it so the choice is visible; feel free to close it.
What this PR does
PuffinExperiment.spo2CandidateDisplayEnabledand the Settings@AppStoragedefault; Android:NoopPrefs.spo2CandidateDisplayand its flow.spo2Pctand never scored.Reasoning: the strap computes this value itself during sleep (R18 byte 82, measured in 30 s windows every 1,200 s; the firmware logs "generated a valid SPO2 during sleep"), per LeonardSEO/wearable5.0 FINDINGS §13. It has still not been compared with the official app's SpO2 for a captured night.
Type of change
How it was tested
VitalReadingsTableTestsandVitalSourceResolutionTestsupdated for the new caption; the Android caption test reads the resource, which keeps its id../gradlew testFullDebugUnitTest: 6688 tests, all pass apart from the 2RecoveryDriversTesthalf-tie cases that fail the same way on unmodifiedmain.Tools/i18n_audit.py --ci,Tools/doc_comment_lint.py,docs/protocol-exampleschecks andTools/parity_ledger.py --refresh-derived(derived snapshots included): pass.Toolsunit tests, the parity acceptance suite and the R-R contract: pass apart from the 4test_check_source_referencescases (/varvs/private/vartemp path on macOS) that fail the same way on unmodifiedmain.Strand) builds with this change on my development branch;StrandTestsand the iOS target were not run locally for this branch.app-build.ymlcovers both.Checklist
android/(apart from the 2RecoveryDriversTesthalf-tie cases that fail the same way on unmodifiedmain)StrandDesign/Palette/Metricstokensdocs/CONTRIBUTING.mdStrand.xcodeproj/) or any secrets/keystoresRelated issues
Refs #103
🤖 Generated with Claude Code