Repository navigation
feat(settings): add a milestones card (streak and threshold milestones) - #2822
Open
LeonardSEO wants to merge 1 commit into
Open
LeonardSEO wants to merge 1 commit into
LeonardSEO wants to merge 1 commit into
Conversation
…s own history Pure math in StrandAnalytics Achievements with a Kotlin twin and mirrored fixtures. Settings card on Android and Apple. Display-only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Adds a Milestones card under the streak card in Settings on Android and macOS/iOS: eight milestones unlocked on the first day the user's own stored metrics reach them, with the unlock date and a NEW tag for the last 7 days.
Streaks are consecutive civil days with a score; same-day duplicates count once. Values outside each metric's plausible range never unlock anything.
Pure math in
Achievements(StrandAnalytics) with a Kotlin twin and mirrored fixtures. Display-only. No celebration screen.The official app's achievements are server-driven; this is a local equivalent.
Type of change
How it was tested
AchievementsTests/AchievementsTest(same fixtures: streak unlock day, gaps reset the run, same-day duplicates count once, threshold milestones, implausible rows ignored, NEW window).swift testinPackages/StrandAnalytics: 2145 tests pass../gradlew testFullDebugUnitTest: 6690 tests, all pass apart from the 2RecoveryDriversTesthalf-tie cases that fail the same way on unmodifiedmain.Tools/i18n_audit.py --ci,Tools/doc_comment_lint.py,docs/protocol-exampleschecks andTools/parity_ledger.py --refresh-derived(derived snapshots included): pass.Toolsunit tests, the parity acceptance suite and the R-R contract: pass apart from the 4test_check_source_referencescases (/varvs/private/vartemp path on macOS) that fail the same way on unmodifiedmain.Strand) builds with this change on my development branch;StrandTestsand the iOS target were not run locally for this branch.app-build.ymlcovers both.Checklist
android/(apart from the 2RecoveryDriversTesthalf-tie cases that fail the same way on unmodifiedmain)StrandDesign/Palette/Metricstokensdocs/CONTRIBUTING.mdStrand.xcodeproj/) or any secrets/keystoresRelated issues
Builds on the streak card (#569).
🤖 Generated with Claude Code