Repository navigation
feat(settings): add a weekly plan card (sleep, Effort and steps goals, Monday to Sunday) - #2821
Open
LeonardSEO wants to merge 1 commit into
Open
LeonardSEO wants to merge 1 commit into
LeonardSEO wants to merge 1 commit into
Conversation
…to Sunday Pure math in StrandAnalytics WeeklyPlan with a Kotlin twin and mirrored fixtures. Days per week stored locally under the same keys on both platforms. Display-only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Adds a Weekly plan card under the streak card in Settings on Android and macOS/iOS: this week's progress (Monday to Sunday) toward three goals the user sets in days per week, with a dot per weekday:
Each goal shows "Done", "On track" or "Out of reach this week", and its days per week can be changed with - / + (0 turns a goal off). The day counts are stored locally (
weeklyPlan.<kind>Days, same keys on both platforms, not in.noopbak). Values outside each metric's plausible range never count.Pure math in
WeeklyPlan(StrandAnalytics) with a Kotlin twin and mirrored fixtures; TZ-free civil-day arithmetic. Display-only.The official app's weekly plan is server-driven; this is a local equivalent with fixed thresholds.
Type of change
How it was tested
WeeklyPlanTests/WeeklyPlanTest(same fixtures: Monday-first weekday index, only this week's days count, implausible values ignored, days left and on-track, goals with 0 days dropped).swift testinPackages/StrandAnalytics: 2146 tests pass../gradlew testFullDebugUnitTest: 6691 tests, all pass apart from the 2RecoveryDriversTesthalf-tie cases that fail the same way on unmodifiedmain.Tools/i18n_audit.py --ci,Tools/doc_comment_lint.py,docs/protocol-exampleschecks andTools/parity_ledger.py --refresh-derived(derived snapshots included): pass.Toolsunit tests, the parity acceptance suite and the R-R contract: pass apart from the 4test_check_source_referencescases (/varvs/private/vartemp path on macOS) that fail the same way on unmodifiedmain.Strand) builds with this change on my development branch;StrandTestsand the iOS target were not run locally for this branch.app-build.ymlcovers both.Checklist
android/(apart from the 2RecoveryDriversTesthalf-tie cases that fail the same way on unmodifiedmain)StrandDesign/Palette/Metricstokensdocs/CONTRIBUTING.mdStrand.xcodeproj/) or any secrets/keystoresRelated issues
None.
🤖 Generated with Claude Code