Repository navigation
Conversation
Apple (Localizable.xcstrings) and Android (values-pt-rPT): - Fix "Descansoaurador/Descansoaurar/..." (a bad find-and-replace of "Rest...") to Restaurador/Restaurar/Restaurado; "Descansoante" -> "Restante". - Replace "cochilo" (pt-BR) with "sesta" and fix the surrounding agreement. - Fix gender/number agreement for "cópia de segurança" (feminine). - "Livro-razão da dívida do sono" -> "Registo da dívida de sono". - "pega" (handle) -> "bracelete" for the strap, the app's dominant term. - "esparso/esparsas" -> "escasso/escassas"; fix swapped placeholders in "Sparse, widened to %@ · %lld readings". - "Band Sleep State": Android pt-PT was "Estado de suspensão da banda"; now "Estado de sono da bracelete". - Minor typos: "tincronização", "tinais", "Detecção" -> "Deteção". "Band Sleep State" had no Apple catalogue entry, so it fell back to English. Added it for the other focus locales too (reusing the Android strings), because the i18n audit fails a new key that lacks them.
- week/month/quarter/year were left in English in the Apple catalogue, which produced captions like "sem week anterior". - "o tempo todo" (all the time) -> "todo o período" for the all-time window. - "toda a histórico" -> "todo o histórico" (Apple and Android). - "versus anterior %@" -> "vs. %@ anterior" (Apple and Android). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
The Portuguese work here is good, and I would like to take it, but the The Spanish regression In Spanish
No Spanish value contains This is invisible to CI: the key set and placeholders are unchanged, so the i18n audit has nothing to flag. I only saw it by parsing the catalogue per locale instead of reading the diff, because the one-line-per-key format rewrites the whole line including every other locale on it. What checks out The 82 pt-PT corrections are exactly right, and several are substantive rather than cosmetic:
The one added key, Two notes for later, not for this PR Several pt-PT values still carry untranslated English tails, for example "so back up first if unsure", "the latest %1$s", and the "Note: continuous background HRV capture..." sentence. Happy to see those in a follow-up. The pt-PT |
The pt-PT 'pega' -> 'bracelete' sweep also rewrote four Spanish AI Coach key-setup strings, where 'pega' is the imperative of 'pegar' (paste). Restore them to their values on main.
|
Thanks for the careful review, and apologies for the regression. The sweep was applied catalogue-wide by mistake. Restored the four Spanish values (Paste your %@ API key, Paste the corrected key, and the two Coach key-setup strings) to their values on main in the latest commit; I verified by parsing the catalogue per locale that no non-pt-PT value differs from main now. Noted on the English tails and the #2784 overlap: happy to do a follow-up for the tails, and I will rebase whichever lands second. |
What this PR does
pt-PT translation corrections from a native speaker, on both platforms (
Strand/Resources/Localizable.xcstringsandandroid/app/src/main/res/values-pt-rPT/strings.xml). Translated values only; no code changes.Not addressed here (code-level, affects every locale, better as a separate change):
TrendsExploreScreen.ktwindowName,MetricExplorerView.swiftrange name).metric.label(Charge/Effort/Rest) instead of a localised label (WeeklyDigestView.swift,WeeklyDigestCard.kt).Type of change
How it was tested
Translation-only change; no BLE, protocol or analytics code touched.
Localizable.xcstringsparses as JSON andvalues-pt-rPT/strings.xmlparses as XML.python -m unittest test_i18n_audit(inTools/): 83 tests OK.python Tools/i18n_audit.py --ci HEAD: output is identical to a cleanmainapart from the un-extracted literal count dropping by one (the new "Band Sleep State" entry).mainalready reports pre-existing zh-Hant/ru gaps, which are unrelated.%@,%lld,%1$s...) are unchanged except the one reordering noted above.Checklist
android/(onlyvalues-pt-rPT/strings.xmlchanged; not run locally)StrandDesigntokens (no UI code changed)docs/CONTRIBUTING.mdStrand.xcodeproj/) or any secrets/keystoresRelated issues
None.