Repository navigation
Keep Apple training pauses and failed saves recoverable - #2759
Open
AlexSchmidt1999 wants to merge 2 commits into
Open
AlexSchmidt1999 wants to merge 2 commits into
AlexSchmidt1999 wants to merge 2 commits into
Conversation
This was referenced Oct 10, 2026
AlexSchmidt1999
marked this pull request as ready for review
October 10, 2026 12:47
This was referenced Oct 10, 2026
Author
|
I am using NOOP 12.1.0 Release build 456 on my iPhone 17 Pro Max, and the app runs very smoothly in everyday use. This PR is included in that combined build, together with my other Apple changes and the performance fixes from #2724 by @UtkuDenizAltiok and #2705 by @kavemang. The installed source is d67cceb5. Both Apple builds and the local app, analytics, database and Python test suites passed for this combined build. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
A workout can disappear from the UI before its database write succeeds. Saving now keeps the session paused and persisted until the writes succeed, allowing a retry after failure. Stable session and set IDs prevent duplicate Lift rows on retry. Retrying also removes pending rows that were removed from the session after a partial save.
Lift Log gains pause and resume through the existing engine and controller. Active and rest timers freeze, rest buzzes stop, and typed values survive. Session RPE moves into the controller. The screen and external callers share the same save path, with no database migration.
Two regressions found during preparation are also fixed. Previous set values reload when an exercise is added, and choosing a program while a session is active reopens that session. This changes Apple training. Android session behavior stays the same.
Type of change
How it was tested
SQLite failure fixtures cover retryable workout and Lift saves. Tests also cover frozen timers, persisted fields, retained input, added-exercise history, and reopening an active session. A controlled physical-strap rest-buzz test has not been recorded.
The focused macOS tests and iOS Release build passed on this PR head. Source hygiene and iOS translation checks passed too.
Checklist
GitHub validation was rechecked on October 11 at
b27493a22962. All 6 registered checks passed, including the macOS app build and tests and the iOS app build.