Repository navigation
fix(ble): reject incomplete standard heart-rate fields - #2747
Open
UtkuDenizAltiok wants to merge 1 commit into
Open
UtkuDenizAltiok wants to merge 1 commit into
UtkuDenizAltiok wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
A truncated Heart Rate Measurement could still publish a plausible heart rate. For example,
[08,48]declares a two-byte energy field but contains none;[10,48,00,04,ff]ends with half an R-R word. Reject incomplete declared fields before live-state or collection effects on Apple and Android.A paired pure protocol predicate gates all three decoders. Existing field decoders, WHOOP 5 raw-millisecond handling, complete-field HR/R-R/contact results, reserved flags, empty R-R compatibility and undeclared trailers remain unchanged. No radio commands, sampling, schema or physiological formulas change.
Type of change
How it was tested
Checklist
Evidence
Contract and source comparisons. Source head: d84f5a1.