Repository navigation
Conversation
kavemang
marked this pull request as ready for review
October 11, 2026 01:19
Regenerate derived parity authority against the merged declarations while retaining production fold regression tests and removing the unused helper. Refs #2708
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
The recalibration tests call
epochDropDiagnostic, an unused helper that independently repeats the production cutoff rule. Remove that helper and run the assertions directly through the unchanged epoch-awareBaselines.foldHistory.Compare the full baseline state with a fold of only the retained suffix, covering strict midnight and one-second-after-midnight cutoffs, discarded missing/outlying nights, empty retained history and disabled recalibration. Preserve the reported three-night calibration case and verify that a fourth retained night makes the baseline usable. Keep the existing file path and restore the fold's documentation attachment.
Type of change
How it was tested
swift test --jobs 1with cached dependencies and installed snapshot-enabled SQLite. The six production recalibration cases also passed independently through the package test target.<to<=) was rejected by three of the six methods, with seven failed assertions, including the preserved calibration case.python3 Tools/parity_ledger.py --refresh-derived --base origin/mainpassed its guarded offline ratchet against the exact base (289 remaining known findings). The six-line snapshot diff removes one unpaired function and one test-only finding, with no disposition changes.b148754a1b4558debe474a4d21833a2010b63e31: the complete expected 17-check roster passed and was confirmed twice unchanged. All eight package checks, three tools package checks, parity governance, Tools Python, hygiene and i18n succeeded.Android has no
epochDropDiagnostictwin to remove; both platforms' shipped scoring formulas and cutoff behavior are unchanged. This removes only test-only Apple API and improves assertions on the actual Apple production fold. No real strap testing is relevant to this pure analytics test change.Checklist
Related issues
Refs #2708