Repository navigation
Conversation
Retain offload session and lifetime count labels alongside the new main translations in every Android locale. Verify merged registry and readout coverage with guarded parity regeneration and both platform test suites. Refs #2091
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Android's Connection & Sync Test Centre panel shows offload results but omits the session and lifetime row counts it already computes. Show both beside the existing result so a wearer can distinguish progress on an ongoing offload from rows banked across reconnects.
Reuse
ConnectionReadout.sessionRowsand the preferences-backedTestCentre.cumulativeDrainedRowswith the existing active-only log refresh and one-second connection clock. Localize the new labels and empty state in all nine Android resource locales. Apple already displays these counts; its registry now declares the same IDs, with a matching Swift assertion and a Kotlin expectation pinned to compiled Swift registry output. The governance snapshot removes the now-production-used session parser from the test-only caller set (65 → 64), without adding accepted debt.This is the offload-count portion of #2091. Clock-verdict/RTC-warning work and last-frame liveness remain outstanding.
Type of change
How it was tested
--max-workers=2 --no-build-cache --rerun-tasks: all 65 selected tests passed across TestCentreLiveReadoutsTest, ConnectionReadoutTest, TestCentreTest and TestModeRegistryParityTest. All 28 Gradle tasks executed.The first upstream Android run built the APK and ran 6,620 tests, exposing one stale registry parity expectation (6 skipped). Both registry declarations and assertions are aligned in the follow-up; final-head upstream CI passed all 18 expected checks, confirmed twice at
489b8aabbe0ba5ad09e590c6ed21b304bcf3aba8. Android built the APK and executed its full unit-test task successfully; Swift analytics ran all 2,114 tests, including the registry assertion. Both Apple app SDK builds passed, and macOS StrandTests ran 2,269 tests (2 skipped, zero failures).Checklist
Related issues
Refs #2091