Repository navigation
Conversation
kavemang
marked this pull request as ready for review
October 3, 2026 06:09
DX23876
added a commit
to DX23876/noop
that referenced
this pull request
Oct 7, 2026
Adds Log Sleep Mark to Shortcuts with a Bedtime default and a Wake choice. It captures the invocation time without opening NOOP and queues the mark in the App Group; the existing active-scene drain saves it with the captured time. The intent queue moves into PendingIntentQueue, a shared helper tested directly, and malformed entries cannot become a mark. From upstream PR ryanbr#2651 by @kavemang. The fork's goals intent flag stays beside the new queue. The PR's paragraph for docs/IOS.md is not taken: the fork's iOS guide has no Shortcuts section to hold it. Analysis migration required: no
Retain the sleep mark intent translations alongside current main catalog additions. Preserve the typed queue and invocation-time projection. Refs #2266
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Adds Log Sleep Mark to iOS Shortcuts with a Bedtime default and a Wake choice. Running it captures the invocation time without opening NOOP. The existing active-scene drain saves the typed mark when NOOP next becomes active, even after midnight; the reply explicitly says it is queued. This is logging only and does not set sleep bounds or feed detection.
The existing string-array queue format and keys stay compatible with queued moment, buzz and Coach requests. A shared, directly tested helper handles the timestamp/type projection; malformed entries cannot turn into a new mark at drain time or overflow its integer timestamp. Queue callers are serialized on MainActor within the app process. The shared mark path keeps its bedtime default for wrist gestures and uses the canonical typed log line.
This addresses only sleep-mark actions from the issue. Caffeine and water Shortcuts remain outstanding. Android is unchanged because App Intents are an Apple framework; the existing
sleep_markrepresentation (bedtime 0 / wake 1) and sleep algorithms are unchanged.Type of change
How it was tested
No iPhone, Siri, locked-device/App Group protection or strap behavior tested. Draft pending manual Shortcut invocation, selecting both kinds, and verifying the captured timestamp/type after resuming NOOP. Persistence retains the existing Phase-1 one
sleep_markvalue per source/day and timestamp/log history; this does not add a sleep-boundary timeline.Checklist
Related issues
Refs #2266