Repository navigation
Conversation
|
Holding this one, for a single reason that is worth fixing at the source rather than in the data. First, the parts I checked and found fine. The generator learning to write Apple catalog entries is the most useful thing here: localizing the What's New title by hand is a step that gets skipped when the version is pre-bumped, so automating it removes a real footgun from the release flow. And I went looking for a compile-time problem in The problem is this line: APPLE_LOCALES = {"de": "de", "es": "es", "fr": "fr", "pt-PT": "pt-PT",
"pl": "pl", "ru": "ru", "it": "it", "zh-Hans": "zh", "zh-Hant": "zh"}Both Apple Chinese locales read the same It is structural rather than a slip. Android ships one Chinese locale, Apple ships two, and What would land this: a If shipping Simplified as the Traditional fallback is the call you would prefer to make, that is defensible, and plenty of apps do it. But it should be a comment in the generator saying so, not an alias that reads like an oversight, because the rest of this catalog holds the higher standard. Worth saying: your #2248, which I rebased and merged today, supplies |
bcd372e to
a349738
Compare
|
Thanks @kavemang. Localising the What's New headline is the right gap to close: the items were already translatable and the title was the one line of that screen still reaching a reader in English. One concern, and it is specific to which CI leg pays for it. The cost lands on the Release build, which no PR check runs
That file is already the reason the iOS leg of
Three ways to settle it, in the order I would try them:
No objection to the change itself, and if the Release timing comes back flat then the first option settles it on the spot. |
Refs #2037.
Localizes the newest Apple What's New headline through the release-note generator and writes its supplied translations into the Apple catalog. Historical Apple headlines remain English literals. The generator demotes the previous headline lookup when adding a release, so the large Swift releases array keeps exactly one localized-title call instead of accumulating calls across history. Android's existing resource-based headlines are retained.
This takes the maintainer's newest-title-only alternative to the Release-build concern. No Apple Release build or timing comparison was performed on this Linux host, and Debug CI is not presented as Release-performance evidence.
Traditional Chinese remains a separate source:
zh-Hantmaps one to one rather than aliasing Simplified Chinese. The existing distinct historical headline translations are preserved, and the current v12.0 headline now has an explicit Traditional translation too. An audit checked all 13 affected release-note sources against their catalog values and confirmed distinct Chinese scripts.Validation:
5731c628f3c2ad253d89f90e17e3c3b6dea7a75c: native macOS Debug build with StrandTests, iOS Debug simulator build, Android APK/full unit suite, Tools Python, hygiene and i18n. The stable six-check roster, unchanged head and mergeable state were rechecked. Apple CI run. No signing files or generated Xcode project are included.