You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Clarify parity disposition and authority refresh flow - #2511
Explain that the ledger's pipe-separated add-unpaired-function finding is a diagnostic from an old twin map, not an identity accepted by the typed disposition registry.
Point contributors at the guarded derived-snapshot refresh after choosing a twin or an exact disposition, and make the ledger output give that next step.
Worth saying why this one is more than a wording change, @kavemang: the old message misled me four separate times today. FAIL ... has no reviewed compact-baseline disposition reads as an instruction to write a disposition, which is the wrong remedy for an add-unpaired-* finding, and the pipe-separated identity in the message is not the identity the registry accepts either. Both halves of that trap are now named at the point the scan fails.
On #2486, #2487 and #2496 the remedy that actually worked was the one this documents: repair the source, with declared twin references where two twins genuinely moved together, and only then the guarded --refresh-derived. On the constant-pair case --refresh-derived correctly refused, which is exactly the behaviour the new text tells you to expect rather than to work around. So the guidance is confirmed by four independent encounters, not just plausible.
Pinning the new wording in test_parity_ledger.py is the right call too: a diagnostic that tells you the wrong remedy is a defect, so the words belong under test like any other behaviour. 182 tests pass on a clean pick onto main.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
add-unpaired-functionfinding is a diagnostic from an old twin map, not an identity accepted by the typed disposition registry.Refs #2163
Verification
git diff --checkpassed.